From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58907) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHboD-0006jE-Su for qemu-devel@nongnu.org; Mon, 27 Jun 2016 15:03:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bHboA-0008Mo-Mn for qemu-devel@nongnu.org; Mon, 27 Jun 2016 15:03:00 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:52857) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHbo8-0008C3-Dn for qemu-devel@nongnu.org; Mon, 27 Jun 2016 15:02:58 -0400 From: "Emilio G. Cota" Date: Mon, 27 Jun 2016 15:02:01 -0400 Message-Id: <1467054136-10430-16-git-send-email-cota@braap.org> In-Reply-To: <1467054136-10430-1-git-send-email-cota@braap.org> References: <1467054136-10430-1-git-send-email-cota@braap.org> Subject: [Qemu-devel] [RFC 15/30] target-i386: emulate LOCK'ed NEG using cmpxchg helper List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: QEMU Developers , MTTCG Devel Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Richard Henderson , Sergey Fedorov , Alvise Rigo , Peter Maydell Signed-off-by: Emilio G. Cota --- target-i386/translate.c | 34 ++++++++++++++++++++++++++++++---- 1 file changed, 30 insertions(+), 4 deletions(-) diff --git a/target-i386/translate.c b/target-i386/translate.c index fcccb1a..a5a633b 100644 --- a/target-i386/translate.c +++ b/target-i386/translate.c @@ -4800,11 +4800,37 @@ static target_ulong disas_insn(CPUX86State *env, DisasContext *s, } break; case 3: /* neg */ - tcg_gen_neg_tl(cpu_T0, cpu_T0); - if (mod != 3) { - gen_op_st_v(s, ot, cpu_T0, cpu_A0); + if (s->prefix & PREFIX_LOCK) { + TCGLabel *label1; + TCGv a0, t0, t1, t2; + + if (mod == 3) { + goto illegal_op; + } + a0 = tcg_temp_local_new(); + t0 = tcg_temp_local_new(); + t1 = tcg_temp_local_new(); + t2 = tcg_temp_new(); + label1 = gen_new_label(); + + tcg_gen_mov_tl(a0, cpu_A0); + gen_set_label(label1); + gen_op_ld_v(s, ot, t0, a0); + tcg_gen_neg_tl(t1, t0); + gen_cmpxchg(t2, a0, t0, t1, ot); + tcg_gen_brcond_tl(TCG_COND_NE, t2, t0, label1); + tcg_temp_free(t2); + tcg_temp_free(a0); + tcg_temp_free(t1); + tcg_gen_mov_tl(cpu_T0, t0); + tcg_temp_free(t0); } else { - gen_op_mov_reg_v(ot, rm, cpu_T0); + tcg_gen_neg_tl(cpu_T0, cpu_T0); + if (mod != 3) { + gen_op_st_v(s, ot, cpu_T0, cpu_A0); + } else { + gen_op_mov_reg_v(ot, rm, cpu_T0); + } } gen_op_update_neg_cc(); set_cc_op(s, CC_OP_SUBB + ot); -- 2.5.0