qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: peter.maydell@linaro.org, qemu-devel@nongnu.org
Cc: Peter Lieven <pl@kamp.de>,
	qemu-stable@nongnu.org, hongyang.yang@easystack.cn,
	Jason Wang <jasowang@redhat.com>
Subject: [Qemu-devel] [PULL 1/5] net: fix qemu_announce_self not emitting packets
Date: Tue, 28 Jun 2016 11:35:06 +0800	[thread overview]
Message-ID: <1467084910-14643-2-git-send-email-jasowang@redhat.com> (raw)
In-Reply-To: <1467084910-14643-1-git-send-email-jasowang@redhat.com>

From: Peter Lieven <pl@kamp.de>

commit fefe2a78 accidently dropped the code path for injecting
raw packets. This feature is needed for sending gratuitous ARPs
after an incoming migration has completed. The result is increased
network downtime for vservers where the network card is not virtio-net
with the VIRTIO_NET_F_GUEST_ANNOUNCE feature.

Fixes: fefe2a78abde932e0f340b21bded2c86def1d242
Cc: qemu-stable@nongnu.org
Cc: hongyang.yang@easystack.cn
Signed-off-by: Peter Lieven <pl@kamp.de>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
 net/net.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/net.c b/net/net.c
index 5f3e5a9..75bb177 100644
--- a/net/net.c
+++ b/net/net.c
@@ -722,7 +722,7 @@ ssize_t qemu_deliver_packet_iov(NetClientState *sender,
         return 0;
     }
 
-    if (nc->info->receive_iov) {
+    if (nc->info->receive_iov && !(flags & QEMU_NET_PACKET_FLAG_RAW)) {
         ret = nc->info->receive_iov(nc, iov, iovcnt);
     } else {
         ret = nc_sendv_compat(nc, iov, iovcnt, flags);
-- 
2.7.4

  reply	other threads:[~2016-06-28  3:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-28  3:35 [Qemu-devel] [PULL 0/5] Net patches Jason Wang
2016-06-28  3:35 ` Jason Wang [this message]
2016-06-28  3:35 ` [Qemu-devel] [PULL 2/5] net: mipsnet: check transmit buffer size before sending Jason Wang
2016-06-28  3:35 ` [Qemu-devel] [PULL 3/5] Change net/socket.c to use socket_*() functions Jason Wang
2016-06-28  3:35 ` [Qemu-devel] [PULL 4/5] rtl8139: save/load RxMulOk counter (again) Jason Wang
2016-06-28  3:35 ` [Qemu-devel] [PULL 5/5] vmxnet3: Fix reading/writing guest memory specially when behind an IOMMU Jason Wang
2016-06-28 10:07 ` [Qemu-devel] [PULL 0/5] Net patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1467084910-14643-2-git-send-email-jasowang@redhat.com \
    --to=jasowang@redhat.com \
    --cc=hongyang.yang@easystack.cn \
    --cc=peter.maydell@linaro.org \
    --cc=pl@kamp.de \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).