qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Sascha Silbe <silbe@linux.vnet.ibm.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>, Jeff Cody <jcody@redhat.com>
Subject: [Qemu-devel] [PATCH 0/1] Fix iotests race condition by fixing block job rate limiting
Date: Tue, 28 Jun 2016 17:28:40 +0200	[thread overview]
Message-ID: <1467127721-9564-1-git-send-email-silbe@linux.vnet.ibm.com> (raw)

qemu-iotests #141 is relying on the test being able to operate on a
block job it just started before further progress is being made on
this block job. This fails regularly on some hosts because the time
slice is just 100ms and it often takes longer than that to start the
additional processes required to trigger the operation. It's
particularly easy to reproduce under 100% CPU load.

I originally noticed and analysed this during 2.6 hard
freeze. Eventually the legacy rate limiting code currently used by the
block jobs will be replaced by the refactorings to use BlockBackends
which have their own rate limiting implementation. There was some hope
[1] this would land in 2.7, but since it's not in master yet (at least
as of commit a01aef5d) I prepared an alternative fix that can go into
2.7.

Sascha Silbe (1):
  Improve block job rate limiting for small bandwidth values

 block/commit.c           | 13 +++++--------
 block/mirror.c           |  4 +++-
 block/stream.c           | 12 ++++--------
 include/qemu/ratelimit.h | 43 ++++++++++++++++++++++++++++++++++---------
 4 files changed, 46 insertions(+), 26 deletions(-)

[1] mid:20160408123115.GH4700@noname.redhat.com
    "Re: [Qemu-devel] [Qemu-block] [PATCH 6/7] qemu-iotests: 141:
    reduce likelihood of race condition on systems with fast IO" by
    Kevin Wolf <kwolf@redhat.com> on 2016-04-08.
-- 
1.9.1

             reply	other threads:[~2016-06-28 15:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-28 15:28 Sascha Silbe [this message]
2016-06-28 15:28 ` [Qemu-devel] [PATCH 1/1] Improve block job rate limiting for small bandwidth values Sascha Silbe
2016-07-02 13:22   ` Max Reitz
2016-07-04 14:30     ` Sascha Silbe
2016-07-05 16:56       ` Max Reitz
2016-07-05 18:06         ` Sascha Silbe
2016-07-05 18:27           ` Max Reitz
2016-07-05 18:28 ` [Qemu-devel] [PATCH 0/1] Fix iotests race condition by fixing block job rate limiting Max Reitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1467127721-9564-1-git-send-email-silbe@linux.vnet.ibm.com \
    --to=silbe@linux.vnet.ibm.com \
    --cc=jcody@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).