From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Efimov Vasily <real@ispras.ru>
Subject: [Qemu-devel] [PULL 03/32] vmport: identify vmport type by macro TYPE_VMPORT
Date: Tue, 28 Jun 2016 19:33:33 +0200 [thread overview]
Message-ID: <1467135242-874-4-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1467135242-874-1-git-send-email-pbonzini@redhat.com>
From: Efimov Vasily <real@ispras.ru>
Currently vmport device is identified by the string literal. Using a
preprocessor alias instead is preferable.
Signed-off-by: Efimov Vasily <real@ispras.ru>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/misc/vmport.c | 1 -
include/hw/i386/pc.h | 3 ++-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/misc/vmport.c b/hw/misc/vmport.c
index 6896789..c763811 100644
--- a/hw/misc/vmport.c
+++ b/hw/misc/vmport.c
@@ -36,7 +36,6 @@
#define VMPORT_ENTRIES 0x2c
#define VMPORT_MAGIC 0x564D5868
-#define TYPE_VMPORT "vmport"
#define VMPORT(obj) OBJECT_CHECK(VMPortState, (obj), TYPE_VMPORT)
typedef struct VMPortState
diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index 948ed0c..bc85054 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/pc.h
@@ -201,11 +201,12 @@ typedef struct GSIState {
void gsi_handler(void *opaque, int n, int level);
/* vmport.c */
+#define TYPE_VMPORT "vmport"
typedef uint32_t (VMPortReadFunc)(void *opaque, uint32_t address);
static inline void vmport_init(ISABus *bus)
{
- isa_create_simple(bus, "vmport");
+ isa_create_simple(bus, TYPE_VMPORT);
}
void vmport_register(unsigned char command, VMPortReadFunc *func, void *opaque);
--
2.7.4
next prev parent reply other threads:[~2016-06-28 17:34 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-28 17:33 [Qemu-devel] [PULL 00/32] Misc patches for QEMU soft freeze Paolo Bonzini
2016-06-28 17:33 ` [Qemu-devel] [PULL 01/32] ide: move headers to include folder Paolo Bonzini
2016-06-28 17:33 ` [Qemu-devel] [PULL 02/32] pcspk: convert "pit" property type from ptr to link Paolo Bonzini
2016-06-28 17:33 ` Paolo Bonzini [this message]
2016-06-28 17:33 ` [Qemu-devel] [PULL 04/32] pflash: make TYPE_CFI_PFLASH0{1, 2} macros public Paolo Bonzini
2016-06-28 17:33 ` [Qemu-devel] [PULL 05/32] Q35: implement property interfece to several parameters Paolo Bonzini
2016-06-28 17:33 ` [Qemu-devel] [PULL 06/32] pc_q35: configure Q35 instance using properties Paolo Bonzini
2016-06-28 17:33 ` [Qemu-devel] [PULL 07/32] pckbd: handle A20 IRQ as GPIO Paolo Bonzini
2016-06-28 17:33 ` [Qemu-devel] [PULL 08/32] port92: " Paolo Bonzini
2016-06-28 17:33 ` [Qemu-devel] [PULL 09/32] ICH9 SMB: make TYPE_ICH9_SMB_DEVICE macro public Paolo Bonzini
2016-06-28 17:33 ` [Qemu-devel] [PULL 10/32] ich9: call ich9_lpc_update_pic for disabled pirqs Paolo Bonzini
2016-06-28 17:33 ` [Qemu-devel] [PULL 11/32] ich9: clean up ich9_lpc_update_pic/ich9_lpc_update_apic and callers Paolo Bonzini
2016-06-28 17:33 ` [Qemu-devel] [PULL 12/32] ich9: unify pic and ioapic IRQ vectors Paolo Bonzini
2016-06-28 17:33 ` [Qemu-devel] [PULL 13/32] ICH9 LPC: handle GSI as qdev GPIO Paolo Bonzini
2016-06-28 17:33 ` [Qemu-devel] [PULL 14/32] ICH9 LPC: move call of isa_bus_irqs to 'realize' method Paolo Bonzini
2016-06-28 17:33 ` [Qemu-devel] [PULL 15/32] isa: introduce wrapper isa_connect_gpio_out Paolo Bonzini
2016-06-28 17:33 ` [Qemu-devel] [PULL 16/32] MC146818 RTC: add GPIO access to output IRQ Paolo Bonzini
2016-06-28 17:33 ` [Qemu-devel] [PULL 17/32] scsi: esp: fix migration Paolo Bonzini
2016-06-28 17:33 ` [Qemu-devel] [PULL 18/32] vnc: generalize "VNC server running on ..." message Paolo Bonzini
2016-06-28 17:33 ` [Qemu-devel] [PULL 19/32] pci-assign: Move "Invalid ROM" error message to pci-assign-load-rom.c Paolo Bonzini
2016-06-28 17:33 ` [Qemu-devel] [PULL 20/32] target-*: Don't redefine cpu_exec() Paolo Bonzini
2016-06-28 17:33 ` [Qemu-devel] [PULL 21/32] char: clean up remaining chardevs when leaving Paolo Bonzini
2016-07-01 12:34 ` Andrew Jones
2016-07-01 15:18 ` Paolo Bonzini
2016-07-01 15:29 ` Laszlo Ersek
2016-06-28 17:33 ` [Qemu-devel] [PULL 22/32] socket: add listen feature Paolo Bonzini
2016-06-28 17:33 ` [Qemu-devel] [PULL 23/32] socket: unlink unix socket on remove Paolo Bonzini
2016-06-28 17:33 ` [Qemu-devel] [PULL 24/32] iscsi: fix assertion in is_sector_request_lun_aligned Paolo Bonzini
2016-06-28 17:33 ` [Qemu-devel] [PULL 25/32] serial: make tsr_retry unsigned Paolo Bonzini
2016-06-28 17:33 ` [Qemu-devel] [PULL 26/32] serial: simplify tsr_retry reset Paolo Bonzini
2016-06-28 17:33 ` [Qemu-devel] [PULL 27/32] serial: separate serial_xmit and serial_watch_cb Paolo Bonzini
2016-06-28 17:33 ` [Qemu-devel] [PULL 28/32] char: change qemu_chr_fe_add_watch to return unsigned Paolo Bonzini
2016-06-28 17:33 ` [Qemu-devel] [PULL 29/32] serial: remove watch on reset Paolo Bonzini
2016-06-28 17:34 ` [Qemu-devel] [PULL 30/32] serial: reinstate watch after migration Paolo Bonzini
2016-06-28 17:34 ` [Qemu-devel] [PULL 31/32] ich9: implement ACPI_EN register Paolo Bonzini
2016-06-28 17:34 ` [Qemu-devel] [PULL 32/32] ich9: implement SCI_IRQ_SEL register Paolo Bonzini
2016-06-29 9:42 ` [Qemu-devel] [PULL 00/32] Misc patches for QEMU soft freeze Peter Maydell
2016-06-29 10:42 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467135242-874-4-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=real@ispras.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).