From: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
To: qemu-ppc@nongnu.org, david@gibson.dropbear.id.au
Cc: qemu-devel@nongnu.org, clg@kaod.org, benh@kernel.crashing.org,
nikunj@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH v2 6/8] ppc/xics: An ICS with offset 0 is assumed to be uninitialized
Date: Wed, 29 Jun 2016 00:35:17 +0530 [thread overview]
Message-ID: <1467140719-4701-7-git-send-email-nikunj@linux.vnet.ibm.com> (raw)
In-Reply-To: <1467140719-4701-1-git-send-email-nikunj@linux.vnet.ibm.com>
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
This will make life easier for dealing with dynamically configured
ICSes such as PHB3
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
---
include/hw/ppc/xics.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/hw/ppc/xics.h b/include/hw/ppc/xics.h
index 6ad3057..8c22daf 100644
--- a/include/hw/ppc/xics.h
+++ b/include/hw/ppc/xics.h
@@ -150,7 +150,7 @@ struct ICSState {
static inline bool ics_valid_irq(ICSState *ics, uint32_t nr)
{
- return (nr >= ics->offset)
+ return (ics->offset != 0) && (nr >= ics->offset)
&& (nr < (ics->offset + ics->nr_irqs));
}
--
2.7.4
next prev parent reply other threads:[~2016-06-28 19:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-28 19:05 [Qemu-devel] [PATCH v2 0/8] sPAPR xics rework/cleanup Nikunj A Dadhania
2016-06-28 19:05 ` [Qemu-devel] [PATCH v2 1/8] ppc/xics: Rename existing xics to xics_spapr Nikunj A Dadhania
2016-06-28 19:05 ` [Qemu-devel] [PATCH v2 2/8] ppc/xics: Move SPAPR specific code to a separate file Nikunj A Dadhania
2016-06-28 19:05 ` [Qemu-devel] [PATCH v2 3/8] ppc/xics: Implement H_IPOLL using an accessor Nikunj A Dadhania
2016-06-28 19:05 ` [Qemu-devel] [PATCH v2 4/8] ppc/xics: Replace "icp" with "xics" in most places Nikunj A Dadhania
2016-06-28 19:05 ` [Qemu-devel] [PATCH v2 5/8] ppc/xics: Make the ICSState a list Nikunj A Dadhania
2016-06-29 3:37 ` David Gibson
2016-06-29 4:05 ` Benjamin Herrenschmidt
2016-06-28 19:05 ` Nikunj A Dadhania [this message]
2016-06-28 19:05 ` [Qemu-devel] [PATCH v2 7/8] ppc/xics: Use a helper to add a new ICS Nikunj A Dadhania
2016-06-28 19:05 ` [Qemu-devel] [PATCH v2 8/8] ppc/xics: Split ICS into ics-base and ics class Nikunj A Dadhania
2016-06-30 8:24 ` Cédric Le Goater
2016-06-30 9:54 ` Nikunj A Dadhania
2016-06-29 3:40 ` [Qemu-devel] [PATCH v2 0/8] sPAPR xics rework/cleanup David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467140719-4701-7-git-send-email-nikunj@linux.vnet.ibm.com \
--to=nikunj@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).