From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46352) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bI2gQ-0007Ay-4b for qemu-devel@nongnu.org; Tue, 28 Jun 2016 19:44:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bI2gK-0000ve-KN for qemu-devel@nongnu.org; Tue, 28 Jun 2016 19:44:46 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:40695) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bI2gK-0000vL-Cc for qemu-devel@nongnu.org; Tue, 28 Jun 2016 19:44:40 -0400 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u5SNhwTx017175 for ; Tue, 28 Jun 2016 19:44:39 -0400 Received: from e31.co.us.ibm.com (e31.co.us.ibm.com [32.97.110.149]) by mx0a-001b2d01.pphosted.com with ESMTP id 23usu9pab4-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 28 Jun 2016 19:44:38 -0400 Received: from localhost by e31.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 28 Jun 2016 17:44:38 -0600 From: Michael Roth Date: Tue, 28 Jun 2016 18:43:46 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Message-Id: <1467157426-6461-1-git-send-email-mdroth@linux.vnet.ibm.com> Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH] configure: mark qemu-ga VSS includes as system headers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Thomas Huth , Stefan Weil , Paolo Bonzini As of e4650c81, we do w32 builds with -Werror enabled. Unfortunately for cases where we enable VSS support in qemu-ga, we still have warnings generated by VSS includes that ship as part of the Microsoft VSS SDK. We can selectively address a number of these warnings using #pragma GCC diagnostic ignored ... but at least one of these: warning: =E2=80=98typedef=E2=80=99 was ignored in this declaration resulting from declarations of the form: typedef struct Blah { ... }; does not provide a specific command-line/pragma option to disable warnings of the sort. To allow VSS builds to succeed, the next-best option is disabling these warnings on a per-file basis. pragmas like #pragma GCC system_header can be used to declare subsequent includes/declarations as being exempt from normal warnings, but this must be done within a header file. Since we don't control the VSS SDK, we'd need to rely on a intermediate header include to accomplish this, and since different objects in the VSS link target rely on different headers from the VSS SDK, this would become somewhat of a rat's nest (though not totally unmanageable). The next step up in granularity is just marking the entire VSS SDK include path as system headers via -isystem. This is a bit more heavy-handed, but since this SDK hasn't changed since 2005, there's likely little to be gained from selectively disabling warnings anyway, so we implement that approach here. This fixes the -Werror failures in both the configure test and the qga build due to shared reliance on $vss_win32_include. For the same reason, this also enforces a new dependency on -isystem support in the C/C++ compiler when building QGA with VSS enabled. Cc: Thomas Huth Cc: Stefan Weil Cc: Paolo Bonzini Signed-off-by: Michael Roth --- configure | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/configure b/configure index e14e907..2d84bc5 100755 --- a/configure +++ b/configure @@ -4049,13 +4049,13 @@ fi =20 if test "$mingw32" =3D "yes" -a "$guest_agent" !=3D "no" -a "$vss_win32_= sdk" !=3D "no" ; then case "$vss_win32_sdk" in - "") vss_win32_include=3D"-I$source_path" ;; + "") vss_win32_include=3D"-isystem $source_path" ;; *\ *) # The SDK is installed in "Program Files" by default, but we c= annot # handle path with spaces. So we symlink the headers into ".sd= k/vss". - vss_win32_include=3D"-I$source_path/.sdk/vss" + vss_win32_include=3D"-isystem $source_path/.sdk/vss" symlink "$vss_win32_sdk/inc" "$source_path/.sdk/vss/inc" ;; - *) vss_win32_include=3D"-I$vss_win32_sdk" + *) vss_win32_include=3D"-isystem $vss_win32_sdk" esac cat > $TMPC << EOF #define __MIDL_user_allocate_free_DEFINED__ --=20 1.9.1