qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, den@openvz.org, kwolf@redhat.com,
	eblake@redhat.com, jsnow@redhat.com, stefanha@redhat.com,
	famz@redhat.com, vsementsov@virtuozzo.com, mreitz@redhat.com
Subject: [Qemu-devel] [PATCH] spec/qcow2: bitmaps: zero bitmap table offset
Date: Wed, 29 Jun 2016 15:22:47 +0300	[thread overview]
Message-ID: <1467202967-497386-1-git-send-email-vsementsov@virtuozzo.com> (raw)

This allows effectively free in_use bitmap clusters including bitmap
table without loss of meaningful data.

Now it is possible only to free end-point clusters and zero-out (not
free) bitmap table

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---

Hi all!

Here is one small but significant addition to specification of bitmaps in qcow2.

Can we apply it just like this or I'll have to inroduce new incompatible feature flag?

If there is existing implementation of the format, it may break image, saved by
software, using extended spec. But is there are any implementations except not
finished my one?


 docs/specs/qcow2.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/docs/specs/qcow2.txt b/docs/specs/qcow2.txt
index 80cdfd0..dd07a82 100644
--- a/docs/specs/qcow2.txt
+++ b/docs/specs/qcow2.txt
@@ -435,6 +435,8 @@ Structure of a bitmap directory entry:
                     Offset into the image file at which the bitmap table
                     (described below) for the bitmap starts. Must be aligned to
                     a cluster boundary.
+                    Zero value means that bitmap table is not allocated and the
+                    bitmap should be considered as empty (all bits are zero).
 
          8 - 11:    bitmap_table_size
                     Number of entries in the bitmap table of the bitmap.
-- 
1.8.3.1

             reply	other threads:[~2016-06-29 12:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-29 12:22 Vladimir Sementsov-Ogievskiy [this message]
2016-06-29 13:24 ` [Qemu-devel] [PATCH] spec/qcow2: bitmaps: zero bitmap table offset Vladimir Sementsov-Ogievskiy
2016-06-29 17:34   ` Max Reitz
2016-06-30  0:33 ` John Snow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1467202967-497386-1-git-send-email-vsementsov@virtuozzo.com \
    --to=vsementsov@virtuozzo.com \
    --cc=den@openvz.org \
    --cc=eblake@redhat.com \
    --cc=famz@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).