qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [Qemu-devel] [PULL 32/35] vhost-user: disable chardev handlers on close
Date: Wed, 29 Jun 2016 17:24:00 +0200	[thread overview]
Message-ID: <1467213840-14206-3-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1467213840-14206-1-git-send-email-pbonzini@redhat.com>

This otherwise causes a use-after-free if network backend cleanup
is performed before character device cleanup.

Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 net/vhost-user.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/net/vhost-user.c b/net/vhost-user.c
index 636899a..92f4cfd 100644
--- a/net/vhost-user.c
+++ b/net/vhost-user.c
@@ -151,6 +151,11 @@ static void vhost_user_cleanup(NetClientState *nc)
         vhost_net_cleanup(s->vhost_net);
         s->vhost_net = NULL;
     }
+    if (s->chr) {
+        qemu_chr_add_handlers(s->chr, NULL, NULL, NULL, NULL);
+        qemu_chr_fe_release(s->chr);
+        s->chr = NULL;
+    }
 
     qemu_purge_queued_packets(nc);
 }
-- 
1.8.3.1

  parent reply	other threads:[~2016-06-29 15:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-29 15:23 [Qemu-devel] [PULL v2 00/35] Misc patches for QEMU soft freeze Paolo Bonzini
2016-06-29 15:23 ` [Qemu-devel] [PULL 31/35] vhost-user-test: fix g_cond_wait_until compat implementation Paolo Bonzini
2016-06-29 15:24 ` Paolo Bonzini [this message]
2016-06-29 15:31   ` [Qemu-devel] [PULL 32/35] vhost-user: disable chardev handlers on close Marc-André Lureau
2016-06-29 15:45     ` Paolo Bonzini
2016-06-30  8:59 ` [Qemu-devel] [PULL v2 00/35] Misc patches for QEMU soft freeze Peter Maydell
2016-06-30 13:11   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1467213840-14206-3-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).