From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57159) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bIWQB-0006XZ-4D for qemu-devel@nongnu.org; Thu, 30 Jun 2016 03:30:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bIWQ7-0006Ea-US for qemu-devel@nongnu.org; Thu, 30 Jun 2016 03:29:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57917) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bIWQ7-0006E6-OG for qemu-devel@nongnu.org; Thu, 30 Jun 2016 03:29:55 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 35D9E63E0E for ; Thu, 30 Jun 2016 07:29:55 +0000 (UTC) From: Markus Armbruster Date: Thu, 30 Jun 2016 09:29:48 +0200 Message-Id: <1467271792-20418-4-git-send-email-armbru@redhat.com> In-Reply-To: <1467271792-20418-1-git-send-email-armbru@redhat.com> References: <1467271792-20418-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PULL 3/7] checkpatch: There is no qemu_strtod() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org From: Eric Blake Maybe there should be; but until there is, we should not flag strtod() calls as something to replaced with qemu_strtod(). We also lack qemu_strtof() and qemu_strtold(), but as no one has been using strtof() or strtold(), it's not worth complicating the regex for them. (Ironically, I had to use 'git commit -n' since checkpatch uses TAB indents, in violation of its own recommendations.) Signed-off-by: Eric Blake Message-Id: <1465526889-8339-3-git-send-email-eblake@redhat.com> Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index c939a32..cf32c8f 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2453,7 +2453,7 @@ sub process { } # recommend qemu_strto* over strto* for numeric conversions - if ($line =~ /\b(strto[^k].*?)\s*\(/) { + if ($line =~ /\b(strto[^kd].*?)\s*\(/) { WARN("consider using qemu_$1 in preference to $1\n" . $herecurr); } # check for module_init(), use category-specific init macros explicitly please -- 2.5.5