[Qemu-devel] [PATCH] qmp: fix spapr example of query-hotpluggable-cpus

[Qemu-devel] [PATCH] qmp: fix spapr example of query-hotpluggable-cpus

[Igor Mammedov]

27393c33 qapi: keep names in 'CpuInstanceProperties' in sync with struct CPUCore
added -id suffix to property names but forgot to fix example in qmp-commands.hx

Fix example to have 'core-id' instead of 'core' to match current code

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
 qmp-commands.hx | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/qmp-commands.hx b/qmp-commands.hx
index b444c20..6937e83 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -4978,8 +4978,8 @@ Example for pseries machine type started with
 
 -> { "execute": "query-hotpluggable-cpus" }
 <- {"return": [
-     { "props": { "core": 8 }, "type": "POWER8-spapr-cpu-core",
+     { "props": { "core-id": 8 }, "type": "POWER8-spapr-cpu-core",
        "vcpus-count": 1 },
-     { "props": { "core": 0 }, "type": "POWER8-spapr-cpu-core",
+     { "props": { "core-id": 0 }, "type": "POWER8-spapr-cpu-core",
        "vcpus-count": 1, "qom-path": "/machine/unattached/device[0]"}
    ]}'
-- 
1.8.3.1

Re: [Qemu-devel] [PATCH] qmp: fix spapr example of query-hotpluggable-cpus

[Peter Krempa]

On Thu, Jun 30, 2016 at 10:17:54 +0200, Igor Mammedov wrote:
> 27393c33 qapi: keep names in 'CpuInstanceProperties' in sync with struct CPUCore
> added -id suffix to property names but forgot to fix example in qmp-commands.hx
> 
> Fix example to have 'core-id' instead of 'core' to match current code
> 
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
>  qmp-commands.hx | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Oops; thanks for cleaning up after me.

Reviewed-by: Peter Krempa <pkrempa@redhat.com>

Re: [Qemu-devel] [PATCH] qmp: fix spapr example of query-hotpluggable-cpus

[David Gibson]

[-- Attachment #1: Type: text/plain, Size: 866 bytes --]

On Thu, Jun 30, 2016 at 10:30:53AM +0200, Peter Krempa wrote:
> On Thu, Jun 30, 2016 at 10:17:54 +0200, Igor Mammedov wrote:
> > 27393c33 qapi: keep names in 'CpuInstanceProperties' in sync with struct CPUCore
> > added -id suffix to property names but forgot to fix example in qmp-commands.hx
> > 
> > Fix example to have 'core-id' instead of 'core' to match current code
> > 
> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> > ---
> >  qmp-commands.hx | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Oops; thanks for cleaning up after me.
> 
> Reviewed-by: Peter Krempa <pkrempa@redhat.com>

Applied to ppc-for-2.7, thanks.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]