From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: mst@redhat.com, marcel@redhat.com
Subject: [Qemu-devel] [PATCH 3/4] acpi: provide _PXM method for CPU devices if QEMU is started numa enabled
Date: Thu, 30 Jun 2016 14:23:06 +0200 [thread overview]
Message-ID: <1467289387-47575-4-git-send-email-imammedo@redhat.com> (raw)
In-Reply-To: <1467289387-47575-1-git-send-email-imammedo@redhat.com>
fixes long standing issue where Linux kernel would assing
hotplugged CPU to 1st numa node as it discards proximity
for hotplugged CPUs after SRAT is parsed.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
hw/acpi/cpu.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/hw/acpi/cpu.c b/hw/acpi/cpu.c
index c13b65c..d9cf3ee 100644
--- a/hw/acpi/cpu.c
+++ b/hw/acpi/cpu.c
@@ -4,6 +4,7 @@
#include "qapi/error.h"
#include "qapi-event.h"
#include "trace.h"
+#include "sysemu/numa.h"
#define ACPI_CPU_HOTPLUG_REG_LEN 12
#define ACPI_CPU_SELECTOR_OFFSET_WR 0
@@ -503,6 +504,7 @@ void build_cpus_aml(Aml *table, MachineState *machine, CPUHotplugFeatures opts,
/* build Processor object for each processor */
for (i = 0; i < arch_ids->len; i++) {
+ int j;
Aml *dev;
Aml *uid = aml_int(i);
GArray *madt_buf = g_array_new(0, 1, 1);
@@ -546,6 +548,13 @@ void build_cpus_aml(Aml *table, MachineState *machine, CPUHotplugFeatures opts,
aml_arg(1), aml_arg(2))
);
aml_append(dev, method);
+
+ for (j = 0; j < nb_numa_nodes; j++) {
+ if (test_bit(i, numa_info[j].node_cpu)) {
+ aml_append(dev, aml_name_decl("_PXM", aml_int(j)));
+ }
+ }
+
aml_append(cpus_dev, dev);
}
}
--
1.8.3.1
next prev parent reply other threads:[~2016-06-30 12:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-30 12:23 [Qemu-devel] [PATCH 0/4] fix numa node mapping for hotplugged CPUs Igor Mammedov
2016-06-30 12:23 ` [Qemu-devel] [PATCH 1/4] tests: acpi: add CPU hotplug testcase Igor Mammedov
2016-06-30 12:42 ` Marcel Apfelbaum
2016-06-30 12:23 ` [Qemu-devel] [PATCH 2/4] tests: DO NOT APPLY: add APIC.cphp and DSDT.cphp blobs Igor Mammedov
2016-06-30 12:23 ` Igor Mammedov [this message]
2016-06-30 12:48 ` [Qemu-devel] [PATCH 3/4] acpi: provide _PXM method for CPU devices if QEMU is started numa enabled Marcel Apfelbaum
2016-06-30 13:01 ` Igor Mammedov
2016-06-30 13:11 ` Marcel Apfelbaum
2016-06-30 17:48 ` Michael S. Tsirkin
2016-06-30 13:29 ` [Qemu-devel] [PATCH v2 " Igor Mammedov
2016-06-30 17:47 ` [Qemu-devel] [PATCH " Michael S. Tsirkin
2016-07-01 8:12 ` Igor Mammedov
2016-06-30 12:23 ` [Qemu-devel] [PATCH 4/4] tests: acpi: extend cphp testcase with numa check Igor Mammedov
2016-06-30 12:52 ` Marcel Apfelbaum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467289387-47575-4-git-send-email-imammedo@redhat.com \
--to=imammedo@redhat.com \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).