From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL v2 3/7] checkpatch: There is no qemu_strtod()
Date: Thu, 30 Jun 2016 15:42:47 +0200 [thread overview]
Message-ID: <1467294171-31518-4-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1467294171-31518-1-git-send-email-armbru@redhat.com>
From: Eric Blake <eblake@redhat.com>
Maybe there should be; but until there is, we should not flag
strtod() calls as something to replaced with qemu_strtod().
We also lack qemu_strtof() and qemu_strtold(), but as no one
has been using strtof() or strtold(), it's not worth complicating
the regex for them.
(Ironically, I had to use 'git commit -n' since checkpatch uses
TAB indents, in violation of its own recommendations.)
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <1465526889-8339-3-git-send-email-eblake@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index c939a32..cf32c8f 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2453,7 +2453,7 @@ sub process {
}
# recommend qemu_strto* over strto* for numeric conversions
- if ($line =~ /\b(strto[^k].*?)\s*\(/) {
+ if ($line =~ /\b(strto[^kd].*?)\s*\(/) {
WARN("consider using qemu_$1 in preference to $1\n" . $herecurr);
}
# check for module_init(), use category-specific init macros explicitly please
--
2.5.5
next prev parent reply other threads:[~2016-06-30 13:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-30 13:42 [Qemu-devel] [PULL v2 0/7] QAPI patches 2016-06-30 Markus Armbruster
2016-06-30 13:42 ` [Qemu-devel] [PULL v2 1/7] json-streamer: Don't leak tokens on incomplete parse Markus Armbruster
2016-06-30 13:42 ` [Qemu-devel] [PULL v2 2/7] qobject: Correct JSON lexer grammar comments Markus Armbruster
2016-06-30 13:42 ` Markus Armbruster [this message]
2016-06-30 13:42 ` [Qemu-devel] [PULL v2 4/7] qapi: Fix crash on missing alternate member of QAPI struct Markus Armbruster
2016-06-30 13:42 ` [Qemu-devel] [PULL v2 5/7] range: Create range.c for code that should not be inline Markus Armbruster
2016-06-30 13:42 ` [Qemu-devel] [PULL v2 6/7] qapi: Simplify use of range.h Markus Armbruster
2016-06-30 13:42 ` [Qemu-devel] [PULL v2 7/7] qapi: Fix memleak in string visitors on int lists Markus Armbruster
2016-07-01 10:51 ` [Qemu-devel] [PULL v2 0/7] QAPI patches 2016-06-30 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467294171-31518-4-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).