qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Apfelbaum <marcel@redhat.com>
To: qemu-devel@nongnu.org
Cc: marcel@redhat.com, mst@redhat.com, pbonzini@redhat.com,
	imammedo@redhat.com, lersek@redhat.com, ehabkost@redhat.com
Subject: [Qemu-devel]  [PATCH V4 0/6] pxb: fix 64-bit MMIO allocation
Date: Thu, 30 Jun 2016 22:07:14 +0300	[thread overview]
Message-ID: <1467313640-29605-1-git-send-email-marcel@redhat.com> (raw)

64-bit BARs allocations fix for devices behind PXBs/PXB-PCIEs.

In build_crs() the calculation and merging of the ranges already happens
in 64-bit, but the entry boundaries are silently truncated to 32-bit in the
call to aml_dword_memory(). Fix it by handling the 64-bit MMIO ranges separately.

v3 -> v4:
 Addressed Igor's comments (thanks for the productive review!)
 - Split pxb test patch (previously patch 3/3) into the test itself (patch 1/6) and the blobs (patch 6/6).
 - New patch declaring pxb/pxb-pxie as not hot-pluggable.
    - Note that it does not solve the DSDT issue, but it is a prerequisite for the next patch.
 - New patch solving the DSDT issue spotted by Igor.
     - Using V=1 DIFF=diff make check does make it easier to review the ACPI changes, thanks.
 - Patches 4 and 5 untouched (previously patches 1/3 and 2/3) 

v2 -> v3:
 - split original series "pci: better support for 64-bit MMIO allocation" into 2 series:
    - this is the first part dealing with correct 64-bit MMIO ACPI computation
    - the second one will include 64-bit MMIO reservation for PCI hotplug
 - Add pxb/pxb-pcie tests (Igor) - See diffs below (*)
 - Re-based on latest master.
   
v1 -> v2:
 - resolved some styling issues (Laszlo)
 - rebase on latest master (Laszlo)

Thank you,
Marcel

Marcel Apfelbaum (6):
  tests/acpi: add pxb/pxb-pcie tests
  hw/pxb: declare pxb devices as not hot-pluggable
  hw/acpi: fix a DSDT table issue when a pxb is present.
  acpi: refactor pxb crs computation
  hw/apci: handle 64-bit MMIO regions correctly
  tests/acpi: Add pxb/pxb-pcie tests blobs

 hw/i386/acpi-build.c                   | 131 ++++++++++++++++++++++++---------
 hw/pci-bridge/pci_expander_bridge.c    |   2 +
 tests/acpi-test-data/pc/DSDT.pxb       | Bin 0 -> 6280 bytes
 tests/acpi-test-data/q35/DSDT.pxb_pcie | Bin 0 -> 9098 bytes
 tests/bios-tables-test.c               |  37 ++++++++++
 5 files changed, 134 insertions(+), 36 deletions(-)
 create mode 100644 tests/acpi-test-data/pc/DSDT.pxb
 create mode 100644 tests/acpi-test-data/q35/DSDT.pxb_pcie

-- 
2.4.3

             reply	other threads:[~2016-06-30 19:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-30 19:07 Marcel Apfelbaum [this message]
2016-06-30 19:07 ` [Qemu-devel] [PATCH V4 1/6] tests/acpi: add pxb/pxb-pcie tests Marcel Apfelbaum
2016-06-30 19:07 ` [Qemu-devel] [PATCH V4 2/6] hw/pxb: declare pxb devices as not hot-pluggable Marcel Apfelbaum
2016-06-30 19:07 ` [Qemu-devel] [PATCH V4 3/6] hw/acpi: fix a DSDT table issue when a pxb is present Marcel Apfelbaum
2016-06-30 19:07 ` [Qemu-devel] [PATCH V4 4/6] acpi: refactor pxb crs computation Marcel Apfelbaum
2016-06-30 19:07 ` [Qemu-devel] [PATCH V4 5/6] hw/apci: handle 64-bit MMIO regions correctly Marcel Apfelbaum
2016-06-30 19:07 ` [Qemu-devel] [PATCH V4 6/6] tests/acpi: Add pxb/pxb-pcie tests blobs Marcel Apfelbaum
2016-07-01 13:57 ` [Qemu-devel] [PATCH V4 0/6] pxb: fix 64-bit MMIO allocation Laszlo Ersek
2016-07-01 14:15   ` Marcel Apfelbaum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1467313640-29605-1-git-send-email-marcel@redhat.com \
    --to=marcel@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=lersek@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).