qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL 0/6] ipxe: update submodule from 4e03af8ec to 041863191
Date: Fri, 01 Jul 2016 10:30:04 +0200	[thread overview]
Message-ID: <1467361804.15123.107.camel@redhat.com> (raw)
In-Reply-To: <CAFEAcA_Z5v6hbn-7Lj4q_e0puWZCjusJwZjJb2Sn1TWMFr6cjQ@mail.gmail.com>

On Do, 2016-06-30 at 17:37 +0100, Peter Maydell wrote:
> On 30 June 2016 at 17:21, Gerd Hoffmann <kraxel@redhat.com> wrote:
> >   Hi,
> >
> >> Hi. I'm afraid this fails 'make check':
> >> TEST: tests/vmxnet3-test... (pid=19181)
> >> qemu-system-i386: -device vmxnet3: failed to find romfile "efi-vmxnet3.rom"
> >> Broken pipe
> >
> >> Looks like you forgot to add the new rom images to
> >> the BLOBS list in Makefile.
> >
> > Forgot that indeed.  But I think this isn't the reason for this failure.
> > configure creates symlinks for *.rom in case src and build dir are not
> > the same.  So you need to re-run configure to get the new roms symlinked
> > in the build dir so "make check" finds them.
> 
> Awkward. I guess you need to do something to arrange that
> configure is run.

Hmm.

I could apply a pointless whitespace change to configure so make re-runs
it automatically ...

Better ideas?

cheers,
  Gerd

      reply	other threads:[~2016-07-01  8:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-29 10:04 [Qemu-devel] [PULL 0/6] ipxe: update submodule from 4e03af8ec to 041863191 Gerd Hoffmann
2016-06-29 10:04 ` [Qemu-devel] [PULL 1/6] " Gerd Hoffmann
2016-06-29 10:05 ` [Qemu-devel] [PULL 2/6] ipxe: add e1000e rom Gerd Hoffmann
2016-06-29 10:05 ` [Qemu-devel] [PULL 3/6] ipxe: add vmxnet3 rom Gerd Hoffmann
2016-06-29 10:05 ` [Qemu-devel] [PULL 4/6] e1000e: add boot rom Gerd Hoffmann
2016-06-29 10:05 ` [Qemu-devel] [PULL 5/6] vmxnet3: " Gerd Hoffmann
2016-06-29 10:05 ` [Qemu-devel] [PULL 6/6] ipxe: update prebuilt binaries Gerd Hoffmann
2016-06-30  9:49 ` [Qemu-devel] [PULL 0/6] ipxe: update submodule from 4e03af8ec to 041863191 Peter Maydell
2016-06-30 16:21   ` Gerd Hoffmann
2016-06-30 16:37     ` Peter Maydell
2016-07-01  8:30       ` Gerd Hoffmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1467361804.15123.107.camel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).