From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52072)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1bKAPT-0005QJ-Rc
	for qemu-devel@nongnu.org; Mon, 04 Jul 2016 16:24:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1bKAPP-0006Q0-Kk
	for qemu-devel@nongnu.org; Mon, 04 Jul 2016 16:24:02 -0400
Received: from mx1.redhat.com ([209.132.183.28]:42828)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1bKAPP-0006Pv-F3
	for qemu-devel@nongnu.org; Mon, 04 Jul 2016 16:23:59 -0400
Message-ID: <1467663836.15123.208.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Mon, 04 Jul 2016 22:23:56 +0200
In-Reply-To: <20160704152648.GA2039@morn.lan>
References: <1467370471-20554-1-git-send-email-kraxel@redhat.com>
	<1467370471-20554-2-git-send-email-kraxel@redhat.com>
	<20160701154732.GA11200@morn.lan>
	<1467620195.15123.133.camel@redhat.com>
	<7c1baeab-b8b0-93d1-a9a2-054dfd92ece0@redhat.com>
	<1467636384.15123.177.camel@redhat.com>
	<20160704152648.GA2039@morn.lan>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0
Subject: Re: [Qemu-devel] [RFC PATCH 1/2] serial console, output
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin O'Connor <kevin@koconnor.net>
Cc: Paolo Bonzini <pbonzini@redhat.com>, seabios@seabios.org, qemu-devel@nongnu.org

  Hi,

> > void sercon_putchar(char *ptr)
> > {
> >     char c =3D GET_GLOBAL(ptr[0]);
> >     [ ... ]
> >=20
> > ... work?
>=20
> Yes.  See output.c:puts_cs() as an example.  It only works if it's a
> constant string (as opposed to a string built on the stack).

After cleaning up the code only three fixed sequences are left: reset,
clear screen and move cursor right.  Don't think it is worth creating a
putstring function just for these.

cheers,
  Gerd