qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: imammedo@redhat.com, rth@twiddle.net, ehabkost@redhat.com,
	jasowang@redhat.com, marcel@redhat.com, mst@redhat.com,
	pbonzini@redhat.com, jan.kiszka@web.de, rkrcmar@redhat.com,
	alex.williamson@redhat.com, wexu@redhat.com,
	davidkiarie4@gmail.com, peterx@redhat.com
Subject: [Qemu-devel] [PATCH v11 10/28] intel_iommu: define interrupt remap table addr register
Date: Tue,  5 Jul 2016 16:19:11 +0800	[thread overview]
Message-ID: <1467706769-12505-11-git-send-email-peterx@redhat.com> (raw)
In-Reply-To: <1467706769-12505-1-git-send-email-peterx@redhat.com>

Defined Interrupt Remap Table Address register to store IR table
pointer. Also, do proper handling on global command register writes to
store table pointer and its size.

One more debug flag "DEBUG_IR" is added for interrupt remapping.

Signed-off-by: Peter Xu <peterx@redhat.com>
---
 hw/i386/intel_iommu.c          | 52 +++++++++++++++++++++++++++++++++++++++++-
 hw/i386/intel_iommu_internal.h |  4 ++++
 include/hw/i386/intel_iommu.h  |  5 ++++
 3 files changed, 60 insertions(+), 1 deletion(-)

diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
index 3d99544..c793031 100644
--- a/hw/i386/intel_iommu.c
+++ b/hw/i386/intel_iommu.c
@@ -33,7 +33,7 @@
 #ifdef DEBUG_INTEL_IOMMU
 enum {
     DEBUG_GENERAL, DEBUG_CSR, DEBUG_INV, DEBUG_MMU, DEBUG_FLOG,
-    DEBUG_CACHE,
+    DEBUG_CACHE, DEBUG_IR,
 };
 #define VTD_DBGBIT(x)   (1 << DEBUG_##x)
 static int vtd_dbgflags = VTD_DBGBIT(GENERAL) | VTD_DBGBIT(CSR);
@@ -903,6 +903,19 @@ static void vtd_root_table_setup(IntelIOMMUState *s)
                 (s->root_extended ? "(extended)" : ""));
 }
 
+static void vtd_interrupt_remap_table_setup(IntelIOMMUState *s)
+{
+    uint64_t value = 0;
+    value = vtd_get_quad_raw(s, DMAR_IRTA_REG);
+    s->intr_size = 1UL << ((value & VTD_IRTA_SIZE_MASK) + 1);
+    s->intr_root = value & VTD_IRTA_ADDR_MASK;
+
+    /* TODO: invalidate interrupt entry cache */
+
+    VTD_DPRINTF(CSR, "int remap table addr 0x%"PRIx64 " size %"PRIu32,
+                s->intr_root, s->intr_size);
+}
+
 static void vtd_context_global_invalidate(IntelIOMMUState *s)
 {
     s->context_cache_gen++;
@@ -1141,6 +1154,16 @@ static void vtd_handle_gcmd_srtp(IntelIOMMUState *s)
     vtd_set_clear_mask_long(s, DMAR_GSTS_REG, 0, VTD_GSTS_RTPS);
 }
 
+/* Set Interrupt Remap Table Pointer */
+static void vtd_handle_gcmd_sirtp(IntelIOMMUState *s)
+{
+    VTD_DPRINTF(CSR, "set Interrupt Remap Table Pointer");
+
+    vtd_interrupt_remap_table_setup(s);
+    /* Ok - report back to driver */
+    vtd_set_clear_mask_long(s, DMAR_GSTS_REG, 0, VTD_GSTS_IRTPS);
+}
+
 /* Handle Translation Enable/Disable */
 static void vtd_handle_gcmd_te(IntelIOMMUState *s, bool en)
 {
@@ -1180,6 +1203,10 @@ static void vtd_handle_gcmd_write(IntelIOMMUState *s)
         /* Queued Invalidation Enable */
         vtd_handle_gcmd_qie(s, val & VTD_GCMD_QIE);
     }
+    if (val & VTD_GCMD_SIRTP) {
+        /* Set/update the interrupt remapping root-table pointer */
+        vtd_handle_gcmd_sirtp(s);
+    }
 }
 
 /* Handle write to Context Command Register */
@@ -1841,6 +1868,23 @@ static void vtd_mem_write(void *opaque, hwaddr addr,
         vtd_update_fsts_ppf(s);
         break;
 
+    case DMAR_IRTA_REG:
+        VTD_DPRINTF(IR, "DMAR_IRTA_REG write addr 0x%"PRIx64
+                    ", size %d, val 0x%"PRIx64, addr, size, val);
+        if (size == 4) {
+            vtd_set_long(s, addr, val);
+        } else {
+            vtd_set_quad(s, addr, val);
+        }
+        break;
+
+    case DMAR_IRTA_REG_HI:
+        VTD_DPRINTF(IR, "DMAR_IRTA_REG_HI write addr 0x%"PRIx64
+                    ", size %d, val 0x%"PRIx64, addr, size, val);
+        assert(size == 4);
+        vtd_set_long(s, addr, val);
+        break;
+
     default:
         VTD_DPRINTF(GENERAL, "error: unhandled reg write addr 0x%"PRIx64
                     ", size %d, val 0x%"PRIx64, addr, size, val);
@@ -2034,6 +2078,12 @@ static void vtd_init(IntelIOMMUState *s)
     /* Fault Recording Registers, 128-bit */
     vtd_define_quad(s, DMAR_FRCD_REG_0_0, 0, 0, 0);
     vtd_define_quad(s, DMAR_FRCD_REG_0_2, 0, 0, 0x8000000000000000ULL);
+
+    /*
+     * Interrupt remapping registers, not support extended interrupt
+     * mode for now.
+     */
+    vtd_define_quad(s, DMAR_IRTA_REG, 0, 0xfffffffffffff00fULL, 0);
 }
 
 /* Should not reset address_spaces when reset because devices will still use
diff --git a/hw/i386/intel_iommu_internal.h b/hw/i386/intel_iommu_internal.h
index 5b98a11..309833f 100644
--- a/hw/i386/intel_iommu_internal.h
+++ b/hw/i386/intel_iommu_internal.h
@@ -172,6 +172,10 @@
 #define VTD_RTADDR_RTT              (1ULL << 11)
 #define VTD_RTADDR_ADDR_MASK        (VTD_HAW_MASK ^ 0xfffULL)
 
+/* IRTA_REG */
+#define VTD_IRTA_ADDR_MASK          (VTD_HAW_MASK ^ 0xfffULL)
+#define VTD_IRTA_SIZE_MASK          (0xfULL)
+
 /* ECAP_REG */
 /* (offset >> 4) << 8 */
 #define VTD_ECAP_IRO                (DMAR_IOTLB_REG_OFFSET << 4)
diff --git a/include/hw/i386/intel_iommu.h b/include/hw/i386/intel_iommu.h
index 638d77f..83d1905 100644
--- a/include/hw/i386/intel_iommu.h
+++ b/include/hw/i386/intel_iommu.h
@@ -125,6 +125,11 @@ struct IntelIOMMUState {
     MemoryRegionIOMMUOps iommu_ops;
     GHashTable *vtd_as_by_busptr;   /* VTDBus objects indexed by PCIBus* reference */
     VTDBus *vtd_as_by_bus_num[VTD_PCI_BUS_MAX]; /* VTDBus objects indexed by bus number */
+
+    /* interrupt remapping */
+    bool intr_enabled;              /* Whether guest enabled IR */
+    dma_addr_t intr_root;           /* Interrupt remapping table pointer */
+    uint32_t intr_size;             /* Number of IR table entries */
 };
 
 #endif
-- 
2.4.11

  parent reply	other threads:[~2016-07-05  8:21 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-05  8:19 [Qemu-devel] [PATCH v11 00/28] IOMMU: Enable interrupt remapping for Intel IOMMU Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 01/28] x86-iommu: introduce parent class Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 02/28] intel_iommu: rename VTD_PCI_DEVFN_MAX to x86-iommu Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 03/28] x86-iommu: provide x86_iommu_get_default Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 04/28] x86-iommu: q35: generalize find_add_as() Peter Xu
2016-07-09  8:14   ` Jan Kiszka
2016-07-11  5:32     ` Peter Xu
2016-07-11  5:46       ` David Kiarie
2016-07-11  6:49         ` Peter Xu
2016-07-11  7:16           ` David Kiarie
2016-07-11  7:41             ` Peter Xu
2016-07-11  8:30               ` Paolo Bonzini
2016-07-11  8:40                 ` Peter Xu
2016-07-11  9:11               ` David Kiarie
2016-07-11  9:25                 ` Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 05/28] x86-iommu: introduce "intremap" property Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 06/28] acpi: enable INTR for DMAR report structure Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 07/28] intel_iommu: allow queued invalidation for IR Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 08/28] intel_iommu: set IR bit for ECAP register Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 09/28] acpi: add DMAR scope definition for root IOAPIC Peter Xu
2016-07-05  8:19 ` Peter Xu [this message]
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 11/28] intel_iommu: handle interrupt remap enable Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 12/28] intel_iommu: define several structs for IOMMU IR Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 13/28] intel_iommu: add IR translation faults defines Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 14/28] intel_iommu: Add support for PCI MSI remap Peter Xu
2016-07-13 13:17   ` David Kiarie
2016-07-14  5:23     ` Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 15/28] q35: ioapic: add support for emulated IOAPIC IR Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 16/28] ioapic: introduce ioapic_entry_parse() helper Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 17/28] intel_iommu: add support for split irqchip Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 18/28] x86-iommu: introduce IEC notifiers Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 19/28] ioapic: register IOMMU IEC notifier for ioapic Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 20/28] intel_iommu: Add support for Extended Interrupt Mode Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 21/28] intel_iommu: add SID validation for IR Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 22/28] kvm-irqchip: simplify kvm_irqchip_add_msi_route Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 23/28] kvm-irqchip: i386: add hook for add/remove virq Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 24/28] kvm-irqchip: x86: add msi route notify fn Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 25/28] kvm-irqchip: do explicit commit when update irq Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 26/28] intel_iommu: support all masks in interrupt entry cache invalidation Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 27/28] kvm-all: add trace events for kvm irqchip ops Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 28/28] intel_iommu: disallow kernel-irqchip=on with IR Peter Xu
2016-07-08 16:01 ` [Qemu-devel] [PATCH v11 00/28] IOMMU: Enable interrupt remapping for Intel IOMMU Radim Krčmář
2016-07-08 16:36   ` Paolo Bonzini
2016-07-08 18:06     ` Radim Krčmář

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1467706769-12505-11-git-send-email-peterx@redhat.com \
    --to=peterx@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=davidkiarie4@gmail.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=jan.kiszka@web.de \
    --cc=jasowang@redhat.com \
    --cc=marcel@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rkrcmar@redhat.com \
    --cc=rth@twiddle.net \
    --cc=wexu@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).