qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: imammedo@redhat.com, rth@twiddle.net, ehabkost@redhat.com,
	jasowang@redhat.com, marcel@redhat.com, mst@redhat.com,
	pbonzini@redhat.com, jan.kiszka@web.de, rkrcmar@redhat.com,
	alex.williamson@redhat.com, wexu@redhat.com,
	davidkiarie4@gmail.com, peterx@redhat.com
Subject: [Qemu-devel] [PATCH v11 06/28] acpi: enable INTR for DMAR report structure
Date: Tue,  5 Jul 2016 16:19:07 +0800	[thread overview]
Message-ID: <1467706769-12505-7-git-send-email-peterx@redhat.com> (raw)
In-Reply-To: <1467706769-12505-1-git-send-email-peterx@redhat.com>

In ACPI DMA remapping report structure, enable INTR flag when specified.

Signed-off-by: Peter Xu <peterx@redhat.com>
---
 hw/i386/acpi-build.c          | 14 +++++++++++++-
 include/hw/i386/intel_iommu.h |  2 ++
 2 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 1186401..773b20e 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -59,6 +59,7 @@
 
 #include "qapi/qmp/qint.h"
 #include "qom/qom-qobject.h"
+#include "hw/i386/x86-iommu.h"
 
 #include "hw/acpi/ipmi.h"
 
@@ -2513,6 +2514,10 @@ build_mcfg_q35(GArray *table_data, BIOSLinker *linker, AcpiMcfgInfo *info)
     build_header(linker, table_data, (void *)mcfg, sig, len, 1, NULL, NULL);
 }
 
+/*
+ * VT-d spec 8.1 DMA Remapping Reporting Structure
+ * (version Oct. 2014 or later)
+ */
 static void
 build_dmar_q35(GArray *table_data, BIOSLinker *linker)
 {
@@ -2520,10 +2525,17 @@ build_dmar_q35(GArray *table_data, BIOSLinker *linker)
 
     AcpiTableDmar *dmar;
     AcpiDmarHardwareUnit *drhd;
+    uint8_t dmar_flags = 0;
+    X86IOMMUState *iommu = x86_iommu_get_default();
+
+    assert(iommu);
+    if (iommu->intr_supported) {
+        dmar_flags |= 0x1;      /* Flags: 0x1: INT_REMAP */
+    }
 
     dmar = acpi_data_push(table_data, sizeof(*dmar));
     dmar->host_address_width = VTD_HOST_ADDRESS_WIDTH - 1;
-    dmar->flags = 0;    /* No intr_remap for now */
+    dmar->flags = dmar_flags;
 
     /* DMAR Remapping Hardware Unit Definition structure */
     drhd = acpi_data_push(table_data, sizeof(*drhd));
diff --git a/include/hw/i386/intel_iommu.h b/include/hw/i386/intel_iommu.h
index e36b896..638d77f 100644
--- a/include/hw/i386/intel_iommu.h
+++ b/include/hw/i386/intel_iommu.h
@@ -44,6 +44,8 @@
 #define VTD_HOST_ADDRESS_WIDTH      39
 #define VTD_HAW_MASK                ((1ULL << VTD_HOST_ADDRESS_WIDTH) - 1)
 
+#define DMAR_REPORT_F_INTR          (1)
+
 typedef struct VTDContextEntry VTDContextEntry;
 typedef struct VTDContextCacheEntry VTDContextCacheEntry;
 typedef struct IntelIOMMUState IntelIOMMUState;
-- 
2.4.11

  parent reply	other threads:[~2016-07-05  8:20 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-05  8:19 [Qemu-devel] [PATCH v11 00/28] IOMMU: Enable interrupt remapping for Intel IOMMU Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 01/28] x86-iommu: introduce parent class Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 02/28] intel_iommu: rename VTD_PCI_DEVFN_MAX to x86-iommu Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 03/28] x86-iommu: provide x86_iommu_get_default Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 04/28] x86-iommu: q35: generalize find_add_as() Peter Xu
2016-07-09  8:14   ` Jan Kiszka
2016-07-11  5:32     ` Peter Xu
2016-07-11  5:46       ` David Kiarie
2016-07-11  6:49         ` Peter Xu
2016-07-11  7:16           ` David Kiarie
2016-07-11  7:41             ` Peter Xu
2016-07-11  8:30               ` Paolo Bonzini
2016-07-11  8:40                 ` Peter Xu
2016-07-11  9:11               ` David Kiarie
2016-07-11  9:25                 ` Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 05/28] x86-iommu: introduce "intremap" property Peter Xu
2016-07-05  8:19 ` Peter Xu [this message]
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 07/28] intel_iommu: allow queued invalidation for IR Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 08/28] intel_iommu: set IR bit for ECAP register Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 09/28] acpi: add DMAR scope definition for root IOAPIC Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 10/28] intel_iommu: define interrupt remap table addr register Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 11/28] intel_iommu: handle interrupt remap enable Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 12/28] intel_iommu: define several structs for IOMMU IR Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 13/28] intel_iommu: add IR translation faults defines Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 14/28] intel_iommu: Add support for PCI MSI remap Peter Xu
2016-07-13 13:17   ` David Kiarie
2016-07-14  5:23     ` Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 15/28] q35: ioapic: add support for emulated IOAPIC IR Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 16/28] ioapic: introduce ioapic_entry_parse() helper Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 17/28] intel_iommu: add support for split irqchip Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 18/28] x86-iommu: introduce IEC notifiers Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 19/28] ioapic: register IOMMU IEC notifier for ioapic Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 20/28] intel_iommu: Add support for Extended Interrupt Mode Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 21/28] intel_iommu: add SID validation for IR Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 22/28] kvm-irqchip: simplify kvm_irqchip_add_msi_route Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 23/28] kvm-irqchip: i386: add hook for add/remove virq Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 24/28] kvm-irqchip: x86: add msi route notify fn Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 25/28] kvm-irqchip: do explicit commit when update irq Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 26/28] intel_iommu: support all masks in interrupt entry cache invalidation Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 27/28] kvm-all: add trace events for kvm irqchip ops Peter Xu
2016-07-05  8:19 ` [Qemu-devel] [PATCH v11 28/28] intel_iommu: disallow kernel-irqchip=on with IR Peter Xu
2016-07-08 16:01 ` [Qemu-devel] [PATCH v11 00/28] IOMMU: Enable interrupt remapping for Intel IOMMU Radim Krčmář
2016-07-08 16:36   ` Paolo Bonzini
2016-07-08 18:06     ` Radim Krčmář

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1467706769-12505-7-git-send-email-peterx@redhat.com \
    --to=peterx@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=davidkiarie4@gmail.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=jan.kiszka@web.de \
    --cc=jasowang@redhat.com \
    --cc=marcel@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rkrcmar@redhat.com \
    --cc=rth@twiddle.net \
    --cc=wexu@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).