qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: mttcg@listserver.greensocs.com, qemu-devel@nongnu.org,
	fred.konrad@greensocs.com, a.rigo@virtualopensystems.com,
	serge.fdrv@gmail.com, cota@braap.org, bobby.prani@gmail.com,
	rth@twiddle.net
Cc: mark.burton@greensocs.com, pbonzini@redhat.com,
	jan.kiszka@siemens.com, peter.maydell@linaro.org,
	claudio.fontana@huawei.com,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Peter Crosthwaite" <crosthwaite.peter@gmail.com>
Subject: [Qemu-devel] [PATCH v2 2/6] tcg: set up tb->page_addr before insertion
Date: Tue,  5 Jul 2016 17:18:12 +0100	[thread overview]
Message-ID: <1467735496-16256-3-git-send-email-alex.bennee@linaro.org> (raw)
In-Reply-To: <1467735496-16256-1-git-send-email-alex.bennee@linaro.org>

This ensures that if we find the TB on the slow path that tb->page_addr
is correctly set before being tested.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 translate-all.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/translate-all.c b/translate-all.c
index 96efe48..97e834a 100644
--- a/translate-all.c
+++ b/translate-all.c
@@ -1126,10 +1126,6 @@ static void tb_link_page(TranslationBlock *tb, tb_page_addr_t phys_pc,
 {
     uint32_t h;
 
-    /* add in the hash table */
-    h = tb_hash_func(phys_pc, tb->pc, tb->flags);
-    qht_insert(&tcg_ctx.tb_ctx.htable, tb, h);
-
     /* add in the page list */
     tb_alloc_page(tb, 0, phys_pc & TARGET_PAGE_MASK);
     if (phys_page2 != -1) {
@@ -1138,6 +1134,10 @@ static void tb_link_page(TranslationBlock *tb, tb_page_addr_t phys_pc,
         tb->page_addr[1] = -1;
     }
 
+    /* add in the hash table */
+    h = tb_hash_func(phys_pc, tb->pc, tb->flags);
+    qht_insert(&tcg_ctx.tb_ctx.htable, tb, h);
+
 #ifdef DEBUG_TB_CHECK
     tb_page_check();
 #endif
-- 
2.7.4

  parent reply	other threads:[~2016-07-05 16:18 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-05 16:18 [Qemu-devel] [PATCH v2 0/6] Reduce lock contention on TCG hot-path Alex Bennée
2016-07-05 16:18 ` [Qemu-devel] [PATCH v2 1/6] tcg: Ensure safe tb_jmp_cache lookup out of 'tb_lock' Alex Bennée
2016-07-07 13:52   ` Sergey Fedorov
2016-07-08 14:51   ` Sergey Fedorov
2016-07-05 16:18 ` Alex Bennée [this message]
2016-07-07 14:08   ` [Qemu-devel] [PATCH v2 2/6] tcg: set up tb->page_addr before insertion Sergey Fedorov
2016-07-08  9:40     ` Sergey Fedorov
2016-07-05 16:18 ` [Qemu-devel] [PATCH v2 3/6] tcg: cpu-exec: remove tb_lock from the hot-path Alex Bennée
2016-07-07 14:18   ` Sergey Fedorov
2016-07-08 15:50     ` Sergey Fedorov
2016-07-08 17:34     ` Sergey Fedorov
2016-07-08 18:03       ` Alex Bennée
2016-07-08 18:20         ` Sergey Fedorov
2016-07-08 20:09   ` Sergey Fedorov
2016-07-05 16:18 ` [Qemu-devel] [PATCH v2 4/6] tcg: cpu-exec: factor out TB patching code Alex Bennée
2016-07-05 16:18 ` [Qemu-devel] [PATCH v2 5/6] tcg: introduce tb_lock_recursive() Alex Bennée
2016-07-05 16:18 ` [Qemu-devel] [PATCH v2 6/6] tcg: cpu-exec: roll-up tb_find_fast/slow Alex Bennée
2016-07-07 16:44   ` Sergey Fedorov
2016-07-07 16:44     ` [Qemu-devel] [PATCH 1/3] tcg: Introduce mmap_lock_reset() Sergey Fedorov
2016-07-07 16:44     ` [Qemu-devel] [PATCH 2/3] tcg: Introduce tb_lock_locked() Sergey Fedorov
2016-07-07 16:44     ` [Qemu-devel] [PATCH 3/3] tcg: Avoid bouncing tb_lock between tb_gen_code() and tb_add_jump() Sergey Fedorov
2016-07-07 19:36       ` Alex Bennée
2016-07-07 19:46         ` Sergey Fedorov
2016-07-07 20:36           ` Sergey Fedorov
2016-07-07 21:40             ` Alex Bennée
2016-07-08  8:40       ` Paolo Bonzini
2016-07-08 10:25         ` Sergey Fedorov
2016-07-08 11:02           ` Paolo Bonzini
2016-07-08 12:32             ` Sergey Fedorov
2016-07-08 14:07               ` Paolo Bonzini
2016-07-08 19:55                 ` Sergey Fedorov
2016-07-08 20:18                   ` Paolo Bonzini
2016-07-08 20:24                     ` Sergey Fedorov
2016-07-08 20:52                       ` Paolo Bonzini
2016-07-11 13:06                         ` Sergey Fedorov
2016-07-11 14:03                           ` Paolo Bonzini
2016-07-11 14:27                             ` Sergey Fedorov
2016-07-07 16:04 ` [Qemu-devel] [PATCH v2 0/6] Reduce lock contention on TCG hot-path Emilio G. Cota
2016-07-07 16:13   ` Paolo Bonzini
2016-07-07 19:33     ` Alex Bennée
2016-07-07 19:38   ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1467735496-16256-3-git-send-email-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=a.rigo@virtualopensystems.com \
    --cc=bobby.prani@gmail.com \
    --cc=claudio.fontana@huawei.com \
    --cc=cota@braap.org \
    --cc=crosthwaite.peter@gmail.com \
    --cc=fred.konrad@greensocs.com \
    --cc=jan.kiszka@siemens.com \
    --cc=mark.burton@greensocs.com \
    --cc=mttcg@listserver.greensocs.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=serge.fdrv@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).