From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36040) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKYY3-0008Ek-5Y for qemu-devel@nongnu.org; Tue, 05 Jul 2016 18:10:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bKYXw-0002CR-Qx for qemu-devel@nongnu.org; Tue, 05 Jul 2016 18:10:29 -0400 Message-ID: <1467756609.13965.78.camel@kernel.crashing.org> From: Benjamin Herrenschmidt Date: Wed, 06 Jul 2016 08:10:09 +1000 In-Reply-To: <66622434-90c8-0d15-f140-2ca1eaa8473d@kaod.org> References: <1465267828-10326-1-git-send-email-benh@kernel.crashing.org> <1465267828-10326-8-git-send-email-benh@kernel.crashing.org> <66622434-90c8-0d15-f140-2ca1eaa8473d@kaod.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 8/9] ppc: Add missing slbfee. instruction on ppc64 BookS processors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?C=E9dric?= Le Goater , qemu-ppc@nongnu.org Cc: qemu-devel@nongnu.org, David Gibson On Tue, 2016-07-05 at 19:23 +0200, C=C3=A9dric Le Goater wrote: >=20 >=20 > So, I was trying today to reconciliate the powernv patchset with=C2=A0 > the current HEAD of qemu when I bumped into the old version of this=C2=A0 > patch. I checked the specs and when no slb are found, rt should=C2=A0 > just be 0. The machine check is only generated when multiple > matching=C2=A0 > entries are found. So the above probably needs a fix, at least for=C2=A0 > the NULL case ?=C2=A0 Yes the old patch was broken but I wrote (and already merged) a better one since then. Check upstream qemu :-) The -1 result is now handled in the JITed code to do the right thing (well, afaik). Cheers, Ben.