qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: pkrempa@redhat.com, ehabkost@redhat.com, mst@redhat.com,
	armbru@redhat.com, eduardo.otubo@profitbricks.com,
	marcel@redhat.com, pbonzini@redhat.com, rth@twiddle.net
Subject: [Qemu-devel] [PATCH v3 18/19] target-i386: add x86_cpu_unrealizefn()
Date: Wed,  6 Jul 2016 08:20:54 +0200	[thread overview]
Message-ID: <1467786055-85835-19-git-send-email-imammedo@redhat.com> (raw)
In-Reply-To: <1467786055-85835-1-git-send-email-imammedo@redhat.com>

first remove VCPU from exec loop and only then remove lapic.

Signed-off-by: Chen Fan <chen.fan.fnst@cn.fujitsu.com>
Signed-off-by: Gu Zheng <guz.fnst@cn.fujitsu.com>
Signed-off-by: Zhu Guihua <zhugh.fnst@cn.fujitsu.com>
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
 target-i386/cpu.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 2fa445d..f86dae0 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -2963,6 +2963,20 @@ out:
     }
 }
 
+static void x86_cpu_unrealizefn(DeviceState *dev, Error **errp)
+{
+    X86CPU *cpu = X86_CPU(dev);
+
+#ifndef CONFIG_USER_ONLY
+    cpu_remove_sync(CPU(dev));
+    qemu_unregister_reset(x86_cpu_machine_reset_cb, dev);
+#endif
+
+    if (cpu->apic_state) {
+        object_unparent(OBJECT(cpu->apic_state));
+    }
+}
+
 typedef struct BitProperty {
     uint32_t *ptr;
     uint32_t mask;
@@ -3205,6 +3219,7 @@ static void x86_cpu_common_class_init(ObjectClass *oc, void *data)
 
     xcc->parent_realize = dc->realize;
     dc->realize = x86_cpu_realizefn;
+    dc->unrealize = x86_cpu_unrealizefn;
     dc->props = x86_cpu_properties;
 
     xcc->parent_reset = cc->reset;
-- 
2.7.0

  parent reply	other threads:[~2016-07-06  6:22 UTC|newest]

Thread overview: 77+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-06  6:20 [Qemu-devel] [PATCH v3 00/19] pc: add CPU hot-add/hot-remove with device_add/device_del Igor Mammedov
2016-07-06  6:20 ` [Qemu-devel] [PATCH v3 01/19] target-i386: cpu: use uint32_t for X86CPU.apic_id Igor Mammedov
2016-07-12  2:14   ` Eduardo Habkost
2016-07-13 22:13   ` Bandan Das
2016-07-14  8:10     ` Igor Mammedov
2016-07-06  6:20 ` [Qemu-devel] [PATCH v3 02/19] pc: add x86_topo_ids_from_apicid() Igor Mammedov
2016-07-12  2:21   ` Eduardo Habkost
2016-07-06  6:20 ` [Qemu-devel] [PATCH v3 03/19] pc: extract CPU lookup into a separate function Igor Mammedov
2016-07-12  2:28   ` Eduardo Habkost
2016-07-12 11:38     ` Igor Mammedov
2016-07-12 12:26   ` Eduardo Habkost
2016-07-06  6:20 ` [Qemu-devel] [PATCH v3 04/19] pc: cpu: consolidate apic-id validity checks in pc_cpu_pre_plug() Igor Mammedov
2016-07-12  2:28   ` Eduardo Habkost
2016-07-12 12:01     ` Igor Mammedov
2016-07-12 12:25       ` Eduardo Habkost
2016-07-13 22:16   ` Bandan Das
2016-07-14  8:14     ` Igor Mammedov
2016-07-20 15:12   ` Eduardo Habkost
2016-07-06  6:20 ` [Qemu-devel] [PATCH v3 05/19] target-i386: cpu: replace custom apic-id setter/getter with static property Igor Mammedov
2016-07-06  6:20 ` [Qemu-devel] [PATCH v3 06/19] target-i386: add socket/core/thread properties to X86CPU Igor Mammedov
2016-07-12  2:33   ` Eduardo Habkost
2016-07-13 22:22   ` Bandan Das
2016-07-14  8:18     ` Igor Mammedov
2016-07-06  6:20 ` [Qemu-devel] [PATCH v3 07/19] pc: set APIC ID based on socket/core/thread ids if it's not been set yet Igor Mammedov
2016-07-12  2:48   ` Eduardo Habkost
2016-07-12 12:52     ` Igor Mammedov
2016-07-13 15:00     ` Igor Mammedov
2016-07-13 22:24   ` Bandan Das
2016-07-13 22:38     ` Eduardo Habkost
2016-07-13 22:55       ` Bandan Das
2016-07-06  6:20 ` [Qemu-devel] [PATCH v3 08/19] pc: implement query-hotpluggable-cpus callback Igor Mammedov
2016-07-12  2:54   ` Eduardo Habkost
2016-07-12 12:31     ` Igor Mammedov
2016-07-12 14:14   ` Eric Blake
2016-07-06  6:20 ` [Qemu-devel] [PATCH v3 09/19] pc: delay setting number of boot CPUs to machine_done time Igor Mammedov
2016-07-12  3:29   ` Eduardo Habkost
2016-07-12 12:48     ` Igor Mammedov
2016-07-12 13:42       ` Igor Mammedov
2016-07-12 17:19         ` Eduardo Habkost
2016-07-13  7:44           ` Igor Mammedov
2016-07-12 17:18       ` Eduardo Habkost
2016-07-13  7:56         ` Igor Mammedov
2016-07-13 13:56           ` Eduardo Habkost
2016-07-06  6:20 ` [Qemu-devel] [PATCH v3 10/19] pc: register created initial and hotpluged CPUs in one place pc_cpu_plug() Igor Mammedov
2016-07-13 22:32   ` Bandan Das
2016-07-13 22:44     ` Eduardo Habkost
2016-07-13 22:59       ` Bandan Das
2016-07-13 23:37         ` Eduardo Habkost
2016-07-14  0:35           ` Bandan Das
2016-07-14  9:18           ` Igor Mammedov
2016-07-14 15:03             ` Eduardo Habkost
2016-07-14 15:40               ` Igor Mammedov
2016-07-14 16:43                 ` Eduardo Habkost
2016-07-14 16:50                   ` Igor Mammedov
2016-07-06  6:20 ` [Qemu-devel] [PATCH v3 11/19] pc: cpu: allow device_add to be used with x86 cpu Igor Mammedov
2016-07-06  6:20 ` [Qemu-devel] [PATCH v3 12/19] apic: move MAX_APICS check to 'apic' class Igor Mammedov
2016-07-13 22:47   ` Bandan Das
2016-07-13 23:38     ` Eduardo Habkost
2016-07-14  0:10       ` Bandan Das
2016-07-06  6:20 ` [Qemu-devel] [PATCH v3 13/19] apic: drop APICCommonState.idx and use APIC ID as index in local_apics[] Igor Mammedov
2016-07-06  6:20 ` [Qemu-devel] [PATCH v3 14/19] (kvm)apic: add unrealize callbacks Igor Mammedov
2016-07-06  6:20 ` [Qemu-devel] [PATCH v3 15/19] apic: use apic_id as apic's migration instance_id Igor Mammedov
2016-07-11 17:21   ` Dr. David Alan Gilbert
2016-07-06  6:20 ` [Qemu-devel] [PATCH v3 16/19] target-i386: cpu: do not ignore error and fix apic parent Igor Mammedov
2016-07-13 14:29   ` Eduardo Habkost
2016-07-06  6:20 ` [Qemu-devel] [PATCH v3 17/19] target-i386: fix apic object leak when CPU is deleted Igor Mammedov
2016-07-13 15:04   ` Eduardo Habkost
2016-07-13 15:26     ` Igor Mammedov
2016-07-13 15:46       ` Igor Mammedov
2016-07-13 16:46         ` Eduardo Habkost
2016-07-13 22:54   ` Bandan Das
2016-07-06  6:20 ` Igor Mammedov [this message]
2016-07-13 14:59   ` [Qemu-devel] [PATCH v3 18/19] target-i386: add x86_cpu_unrealizefn() Eduardo Habkost
2016-07-13 15:52     ` Igor Mammedov
2016-07-06  6:20 ` [Qemu-devel] [PATCH v3 19/19] pc: make device_del CPU work for x86 CPUs Igor Mammedov
2016-07-13 14:27 ` [Qemu-devel] [PATCH v3 00/19] pc: add CPU hot-add/hot-remove with device_add/device_del Eduardo Habkost
2016-07-13 14:34   ` Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1467786055-85835-19-git-send-email-imammedo@redhat.com \
    --to=imammedo@redhat.com \
    --cc=armbru@redhat.com \
    --cc=eduardo.otubo@profitbricks.com \
    --cc=ehabkost@redhat.com \
    --cc=marcel@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=pkrempa@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).