From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, mreitz@redhat.com, eblake@redhat.com,
qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v2 04/11] block: Accept node-name for blockdev-mirror
Date: Wed, 6 Jul 2016 17:20:40 +0200 [thread overview]
Message-ID: <1467818447-2728-5-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1467818447-2728-1-git-send-email-kwolf@redhat.com>
In order to remove the necessity to use BlockBackend names in the
external API, we want to allow node-names everywhere. This converts
blockdev-mirror to accept a node-name without lifting the restriction
that we're operating at a root node.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
blockdev.c | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index d9909d0..7e9c7a4 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -3654,21 +3654,13 @@ void qmp_blockdev_mirror(const char *device, const char *target,
Error **errp)
{
BlockDriverState *bs;
- BlockBackend *blk;
BlockDriverState *target_bs;
AioContext *aio_context;
BlockMirrorBackingMode backing_mode = MIRROR_LEAVE_BACKING_CHAIN;
Error *local_err = NULL;
- blk = blk_by_name(device);
- if (!blk) {
- error_setg(errp, "Device '%s' not found", device);
- return;
- }
- bs = blk_bs(blk);
-
+ bs = qmp_get_root_bs(device, errp);
if (!bs) {
- error_setg(errp, "Device '%s' has no media", device);
return;
}
--
1.8.3.1
next prev parent reply other threads:[~2016-07-06 15:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 15:20 [Qemu-devel] [PATCH v2 00/11] block: Accept node-name in all node level QMP commands Kevin Wolf
2016-07-06 15:20 ` [Qemu-devel] [PATCH v2 01/11] block: Accept node-name for block-stream Kevin Wolf
2016-07-06 15:20 ` [Qemu-devel] [PATCH v2 02/11] block: Accept node-name for block-commit Kevin Wolf
2016-07-06 15:20 ` [Qemu-devel] [PATCH v2 03/11] block: Accept node-name for blockdev-backup Kevin Wolf
2016-07-06 15:20 ` Kevin Wolf [this message]
2016-07-06 15:20 ` [Qemu-devel] [PATCH v2 05/11] block: Accept node-name for blockdev-snapshot-delete-internal-sync Kevin Wolf
2016-07-06 15:20 ` [Qemu-devel] [PATCH v2 06/11] block: Accept node-name for blockdev-snapshot-internal-sync Kevin Wolf
2016-07-06 15:20 ` [Qemu-devel] [PATCH v2 07/11] block: Accept node-name for change-backing-file Kevin Wolf
2016-07-06 15:20 ` [Qemu-devel] [PATCH v2 08/11] block: Accept node-name for drive-backup Kevin Wolf
2016-07-06 15:20 ` [Qemu-devel] [PATCH v2 09/11] block: Accept node-name for drive-mirror Kevin Wolf
2016-07-06 15:20 ` [Qemu-devel] [PATCH v2 10/11] nbd-server: Use a separate BlockBackend Kevin Wolf
2016-07-06 15:20 ` [Qemu-devel] [PATCH v2 11/11] nbd-server: Allow node name for nbd-server-add Kevin Wolf
2016-07-06 15:24 ` [Qemu-devel] [RFC PATCH v2 00/11] block: Accept node-name in all node level QMP commands Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467818447-2728-5-git-send-email-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=eblake@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).