From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59591) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKodo-0000Ij-Lt for qemu-devel@nongnu.org; Wed, 06 Jul 2016 11:21:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bKodj-0000nl-W3 for qemu-devel@nongnu.org; Wed, 06 Jul 2016 11:21:32 -0400 From: Kevin Wolf Date: Wed, 6 Jul 2016 17:20:40 +0200 Message-Id: <1467818447-2728-5-git-send-email-kwolf@redhat.com> In-Reply-To: <1467818447-2728-1-git-send-email-kwolf@redhat.com> References: <1467818447-2728-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH v2 04/11] block: Accept node-name for blockdev-mirror List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: kwolf@redhat.com, mreitz@redhat.com, eblake@redhat.com, qemu-devel@nongnu.org In order to remove the necessity to use BlockBackend names in the external API, we want to allow node-names everywhere. This converts blockdev-mirror to accept a node-name without lifting the restriction that we're operating at a root node. Signed-off-by: Kevin Wolf --- blockdev.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/blockdev.c b/blockdev.c index d9909d0..7e9c7a4 100644 --- a/blockdev.c +++ b/blockdev.c @@ -3654,21 +3654,13 @@ void qmp_blockdev_mirror(const char *device, const char *target, Error **errp) { BlockDriverState *bs; - BlockBackend *blk; BlockDriverState *target_bs; AioContext *aio_context; BlockMirrorBackingMode backing_mode = MIRROR_LEAVE_BACKING_CHAIN; Error *local_err = NULL; - blk = blk_by_name(device); - if (!blk) { - error_setg(errp, "Device '%s' not found", device); - return; - } - bs = blk_bs(blk); - + bs = qmp_get_root_bs(device, errp); if (!bs) { - error_setg(errp, "Device '%s' has no media", device); return; } -- 1.8.3.1