From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52769) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKqxH-0006TQ-DL for qemu-devel@nongnu.org; Wed, 06 Jul 2016 13:49:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bKqxC-0004yr-RA for qemu-devel@nongnu.org; Wed, 06 Jul 2016 13:49:47 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:24770) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKqxC-0004yg-Hn for qemu-devel@nongnu.org; Wed, 06 Jul 2016 13:49:42 -0400 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u66HflqD118617 for ; Wed, 6 Jul 2016 13:49:40 -0400 Received: from e23smtp07.au.ibm.com (e23smtp07.au.ibm.com [202.81.31.140]) by mx0a-001b2d01.pphosted.com with ESMTP id 2415xjstt3-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 06 Jul 2016 13:49:40 -0400 Received: from localhost by e23smtp07.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 7 Jul 2016 03:49:38 +1000 From: Bharata B Rao Date: Wed, 6 Jul 2016 23:19:30 +0530 Message-Id: <1467827370-8808-1-git-send-email-bharata@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH v0] spapr: Error out when CPU hotplug is attempted on older pseries machines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, david@gibson.dropbear.id.au, Bharata B Rao CPU hotplug and coldplug aren't supported prior to pseries-2.7. query-hotpluggable-cpus and coldplug on older pseries machines are crashing the QEMU. Fix this. - Let query_hotpluggable_cpus return NULL for pseries < 2.7 - spapr_core_pre_plug() should fail hot/cold plug attempts for pseries < 2.7 - spapr_core_plug() should never be called for pseries < 2.7, hence use an assert. Signed-off-by: Bharata B Rao --- Applies on ppc-for-2.7 branch of David's tree. hw/ppc/spapr.c | 5 +++++ hw/ppc/spapr_cpu_core.c | 19 ++++++------------- 2 files changed, 11 insertions(+), 13 deletions(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 7f33a1b..e3a7912 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -2368,9 +2368,14 @@ static HotpluggableCPUList *spapr_query_hotpluggable_cpus(MachineState *machine) int i; HotpluggableCPUList *head = NULL; sPAPRMachineState *spapr = SPAPR_MACHINE(machine); + sPAPRMachineClass *smc = SPAPR_MACHINE_GET_CLASS(machine); int spapr_max_cores = max_cpus / smp_threads; int smt = kvmppc_smt_threads(); + if (!smc->dr_cpu_enabled) { + return NULL; + } + for (i = 0; i < spapr_max_cores; i++) { HotpluggableCPUList *list_item = g_new0(typeof(*list_item), 1); HotpluggableCPU *cpu_item = g_new0(typeof(*cpu_item), 1); diff --git a/hw/ppc/spapr_cpu_core.c b/hw/ppc/spapr_cpu_core.c index 70b6b0b..273207c 100644 --- a/hw/ppc/spapr_cpu_core.c +++ b/hw/ppc/spapr_cpu_core.c @@ -162,19 +162,12 @@ void spapr_core_plug(HotplugHandler *hotplug_dev, DeviceState *dev, int index; int smt = kvmppc_smt_threads(); + g_assert(smc->dr_cpu_enabled); + drc = spapr_dr_connector_by_id(SPAPR_DR_CONNECTOR_TYPE_CPU, cc->core_id); index = cc->core_id / smt; spapr->cores[index] = OBJECT(dev); - if (!smc->dr_cpu_enabled) { - /* - * This is a cold plugged CPU core but the machine doesn't support - * DR. So skip the hotplug path ensuring that the core is brought - * up online with out an associated DR connector. - */ - return; - } - g_assert(drc); /* @@ -223,13 +216,13 @@ void spapr_core_pre_plug(HotplugHandler *hotplug_dev, DeviceState *dev, char *base_core_type = spapr_get_cpu_core_type(machine->cpu_model); const char *type = object_get_typename(OBJECT(dev)); - if (strcmp(base_core_type, type)) { - error_setg(&local_err, "CPU core type should be %s", base_core_type); + if (!smc->dr_cpu_enabled) { + error_setg(&local_err, "CPU hotplug not supported for this machine"); goto out; } - if (!smc->dr_cpu_enabled && dev->hotplugged) { - error_setg(&local_err, "CPU hotplug not supported for this machine"); + if (strcmp(base_core_type, type)) { + error_setg(&local_err, "CPU core type should be %s", base_core_type); goto out; } -- 2.7.4