From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [RfC PATCH] gtk: prefer version 3.x
Date: Thu, 7 Jul 2016 09:34:47 +0200 [thread overview]
Message-ID: <1467876887-2259-1-git-send-email-kraxel@redhat.com> (raw)
This patch flips the default from gtk2 to gtk3.
Sounds like a bigger change than it actually is as configure already
uses gtk3 in case it doesn't find gtk2. So this changes behavior
only in case both gtk2 and gtk3 devel packages are installed.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
configure | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/configure b/configure
index e9090a0..e029eee 100755
--- a/configure
+++ b/configure
@@ -2154,11 +2154,9 @@ fi
# GTK probe
if test "$gtkabi" = ""; then
- # The GTK ABI was not specified explicitly, so try whether 2.0 is available.
- # Use 3.0 as a fallback if that is available.
- if $pkg_config --exists "gtk+-2.0 >= 2.18.0"; then
- gtkabi=2.0
- elif $pkg_config --exists "gtk+-3.0 >= 3.0.0"; then
+ # The GTK ABI was not specified explicitly, so try whether 3.0 is available.
+ # Use 2.0 as a fallback.
+ if $pkg_config --exists "gtk+-3.0 >= 3.0.0"; then
gtkabi=3.0
else
gtkabi=2.0
--
1.8.3.1
next reply other threads:[~2016-07-07 7:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-07 7:34 Gerd Hoffmann [this message]
2016-07-07 9:29 ` [Qemu-devel] [RfC PATCH] gtk: prefer version 3.x Daniel P. Berrange
2016-07-07 9:57 ` Peter Maydell
2016-07-07 14:27 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467876887-2259-1-git-send-email-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).