From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50573) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLDVe-0008E9-VB for qemu-devel@nongnu.org; Thu, 07 Jul 2016 13:54:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bLDVZ-0002Lu-Rv for qemu-devel@nongnu.org; Thu, 07 Jul 2016 13:54:45 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:39783) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLDVZ-0002LU-JI for qemu-devel@nongnu.org; Thu, 07 Jul 2016 13:54:41 -0400 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u67HhkoJ058893 for ; Thu, 7 Jul 2016 13:54:41 -0400 Received: from e28smtp07.in.ibm.com (e28smtp07.in.ibm.com [125.16.236.7]) by mx0a-001b2d01.pphosted.com with ESMTP id 2415xm5twp-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 07 Jul 2016 13:54:40 -0400 Received: from localhost by e28smtp07.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 7 Jul 2016 23:24:37 +0530 From: Nikunj A Dadhania Date: Thu, 7 Jul 2016 23:24:16 +0530 In-Reply-To: <1467914058-30551-1-git-send-email-nikunj@linux.vnet.ibm.com> References: <1467914058-30551-1-git-send-email-nikunj@linux.vnet.ibm.com> Message-Id: <1467914058-30551-3-git-send-email-nikunj@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH v3 2/4] ppc/xics: An ICS with offset 0 is assumed to be uninitialized List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-ppc@nongnu.org, david@gibson.dropbear.id.au Cc: qemu-devel@nongnu.org, clg@kaod.org, benh@kernel.crashing.org, nikunj@linux.vnet.ibm.com From: Benjamin Herrenschmidt This will make life easier for dealing with dynamically configured ICSes such as PHB3 Signed-off-by: Benjamin Herrenschmidt Reviewed-by: David Gibson Signed-off-by: Nikunj A Dadhania --- include/hw/ppc/xics.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/ppc/xics.h b/include/hw/ppc/xics.h index 6ad3057..8c22daf 100644 --- a/include/hw/ppc/xics.h +++ b/include/hw/ppc/xics.h @@ -150,7 +150,7 @@ struct ICSState { static inline bool ics_valid_irq(ICSState *ics, uint32_t nr) { - return (nr >= ics->offset) + return (ics->offset != 0) && (nr >= ics->offset) && (nr < (ics->offset + ics->nr_irqs)); } -- 2.7.4