qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <rth@twiddle.net>,
	qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 08/16] target-i386: Avoid using locals outside their scope
Date: Thu,  7 Jul 2016 16:59:14 -0300	[thread overview]
Message-ID: <1467921562-11796-9-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1467921562-11796-1-git-send-email-ehabkost@redhat.com>

From: Paolo Bonzini <pbonzini@redhat.com>

x86_cpu_parse_featurestr has a "val = num;" assignment just before num
goes out of scope.  Push num up to fix the issue.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 target-i386/cpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 2227f22..0b286e1 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1975,6 +1975,7 @@ static void x86_cpu_parse_featurestr(CPUState *cs, char *features,
         const char *name;
         const char *val = NULL;
         char *eq = NULL;
+        char num[32];
 
         /* Compatibility syntax: */
         if (featurestr[0] == '+') {
@@ -2000,7 +2001,6 @@ static void x86_cpu_parse_featurestr(CPUState *cs, char *features,
         if (!strcmp(name, "tsc-freq")) {
             int64_t tsc_freq;
             char *err;
-            char num[32];
 
             tsc_freq = qemu_strtosz_suffix_unit(val, &err,
                                            QEMU_STRTOSZ_DEFSUFFIX_B, 1000);
-- 
2.5.5

  parent reply	other threads:[~2016-07-07 20:00 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-07 19:59 [Qemu-devel] [PULL 00/16] x86 and machine queue, 2016-07-07 Eduardo Habkost
2016-07-07 19:59 ` [Qemu-devel] [PULL 01/16] qdev: Don't stop applying globals on first error Eduardo Habkost
2016-07-07 19:59 ` [Qemu-devel] [PULL 02/16] qdev: Eliminate qemu_add_globals() function Eduardo Habkost
2016-07-07 19:59 ` [Qemu-devel] [PULL 03/16] qdev: GlobalProperty.errp field Eduardo Habkost
2016-07-07 19:59 ` [Qemu-devel] [PULL 04/16] machine: Add machine_register_compat_props() function Eduardo Habkost
2016-07-07 19:59 ` [Qemu-devel] [PULL 05/16] vl: Set errp to &error_abort on machine compat_props Eduardo Habkost
2016-07-07 19:59 ` [Qemu-devel] [PULL 06/16] target-sparc: Use sparc_cpu_parse_features() directly Eduardo Habkost
2016-07-07 19:59 ` [Qemu-devel] [PULL 07/16] target-i386: TCG can support CPUID.07H:EBX.erms Eduardo Habkost
2016-07-07 19:59 ` Eduardo Habkost [this message]
2016-07-07 19:59 ` [Qemu-devel] [PULL 09/16] cpu: Use CPUClass->parse_features() as convertor to global properties Eduardo Habkost
2016-07-07 19:59 ` [Qemu-devel] [PULL 10/16] arm: virt: Parse cpu_model only once Eduardo Habkost
2016-07-07 19:59 ` [Qemu-devel] [PULL 11/16] pc: Parse CPU features " Eduardo Habkost
2016-07-07 19:59 ` [Qemu-devel] [PULL 12/16] target-i386: Show host and VM TSC frequencies on mismatch Eduardo Habkost
2016-07-07 19:59 ` [Qemu-devel] [PULL 13/16] target-i386: Report hyperv feature words through qom Eduardo Habkost
2016-07-07 19:59 ` [Qemu-devel] [PULL 14/16] target-i386: kvm: Add basic Intel LMCE support Eduardo Habkost
2016-07-07 19:59 ` [Qemu-devel] [PULL 15/16] target-i386: Publish advised value of MSR_IA32_FEATURE_CONTROL via fw_cfg Eduardo Habkost
2016-07-07 19:59 ` [Qemu-devel] [PULL 16/16] target-i386: Enable LMCE for '-cpu host' if supported by host Eduardo Habkost
2016-07-11 14:59 ` [Qemu-devel] [PULL 00/16] x86 and machine queue, 2016-07-07 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1467921562-11796-9-git-send-email-ehabkost@redhat.com \
    --to=ehabkost@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).