From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51170) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLFSp-0004Mb-7w for qemu-devel@nongnu.org; Thu, 07 Jul 2016 16:00:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bLFSn-0004NE-58 for qemu-devel@nongnu.org; Thu, 07 Jul 2016 15:59:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60772) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLFSm-0004N9-Vw for qemu-devel@nongnu.org; Thu, 07 Jul 2016 15:59:57 -0400 From: Eduardo Habkost Date: Thu, 7 Jul 2016 16:59:14 -0300 Message-Id: <1467921562-11796-9-git-send-email-ehabkost@redhat.com> In-Reply-To: <1467921562-11796-1-git-send-email-ehabkost@redhat.com> References: <1467921562-11796-1-git-send-email-ehabkost@redhat.com> Subject: [Qemu-devel] [PULL 08/16] target-i386: Avoid using locals outside their scope List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Paolo Bonzini , Richard Henderson , qemu-devel@nongnu.org From: Paolo Bonzini x86_cpu_parse_featurestr has a "val = num;" assignment just before num goes out of scope. Push num up to fix the issue. Signed-off-by: Paolo Bonzini Reviewed-by: Igor Mammedov Reviewed-by: Eduardo Habkost Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 2227f22..0b286e1 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1975,6 +1975,7 @@ static void x86_cpu_parse_featurestr(CPUState *cs, char *features, const char *name; const char *val = NULL; char *eq = NULL; + char num[32]; /* Compatibility syntax: */ if (featurestr[0] == '+') { @@ -2000,7 +2001,6 @@ static void x86_cpu_parse_featurestr(CPUState *cs, char *features, if (!strcmp(name, "tsc-freq")) { int64_t tsc_freq; char *err; - char num[32]; tsc_freq = qemu_strtosz_suffix_unit(val, &err, QEMU_STRTOSZ_DEFSUFFIX_B, 1000); -- 2.5.5