qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: patches@linaro.org, Riku Voipio <riku.voipio@iki.fi>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: [Qemu-devel] [PATCH 6/8] linux-user: Check dump_write() return in elf_core_dump()
Date: Tue, 12 Jul 2016 13:02:17 +0100	[thread overview]
Message-ID: <1468324939-12221-7-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1468324939-12221-1-git-send-email-peter.maydell@linaro.org>

One of the calls to dump_write() in elf_core_dump() was missing
a check for failure (spotted by Coverity). Add the check to
bring it into line with the other calls from this function.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 linux-user/elfload.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index 38e210e..7c46cfb 100644
--- a/linux-user/elfload.c
+++ b/linux-user/elfload.c
@@ -3053,7 +3053,9 @@ static int elf_core_dump(int signr, const CPUArchState *env)
         phdr.p_align = ELF_EXEC_PAGESIZE;
 
         bswap_phdr(&phdr, 1);
-        dump_write(fd, &phdr, sizeof (phdr));
+        if (dump_write(fd, &phdr, sizeof(phdr)) != 0) {
+            goto out;
+        }
     }
 
     /*
-- 
1.9.1

  parent reply	other threads:[~2016-07-12 12:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-12 12:02 [Qemu-devel] [PATCH 0/8] linux-user: fix various coverity nits Peter Maydell
2016-07-12 12:02 ` [Qemu-devel] [PATCH 1/8] linux-user: Pass missing MAP_ANONYMOUS to target_mmap() call Peter Maydell
2016-07-12 12:02 ` [Qemu-devel] [PATCH 2/8] linux-user: Check lock_user() return value for NULL Peter Maydell
2016-07-12 12:02 ` [Qemu-devel] [PATCH 3/8] linux-user: Fix incorrect use of host errno in do_ioctl_dm() Peter Maydell
2016-07-12 12:02 ` [Qemu-devel] [PATCH 4/8] linux-user: Fix error handling in flatload.c target_pread() Peter Maydell
2016-07-12 12:02 ` [Qemu-devel] [PATCH 5/8] linux-user: Don't write off end of new_utsname buffer Peter Maydell
2016-07-12 12:02 ` Peter Maydell [this message]
2016-07-12 12:02 ` [Qemu-devel] [PATCH 7/8] linux-user: Use glib malloc functions in load_symbols() Peter Maydell
2016-07-12 12:02 ` [Qemu-devel] [PATCH 8/8] linux-user: Fix memchr() argument in open_self_cmdline() Peter Maydell
2016-07-12 14:47 ` [Qemu-devel] [PATCH 0/8] linux-user: fix various coverity nits Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1468324939-12221-7-git-send-email-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=patches@linaro.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).