From: Peter Lieven <pl@kamp.de>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, mreitz@redhat.com, pbonzini@redhat.com,
mst@redhat.com, dgilbert@redhat.com, peter.maydell@linaro.org,
eblake@redhat.com, rth@twiddle.net, armbru@redhat.com,
Peter Lieven <pl@kamp.de>
Subject: [Qemu-devel] [PATCH V5 1/6] oslib-posix: add helpers for stack alloc and free
Date: Tue, 12 Jul 2016 18:23:01 +0200 [thread overview]
Message-ID: <1468340586-19304-2-git-send-email-pl@kamp.de> (raw)
In-Reply-To: <1468340586-19304-1-git-send-email-pl@kamp.de>
the allocated stack will be adjusted to the minimum supported stack size
by the OS and rounded up to be a multiple of the system pagesize.
Additionally an architecture dependent guard page is added to the stack
to catch stack overflows.
Signed-off-by: Peter Lieven <pl@kamp.de>
---
include/sysemu/os-posix.h | 23 +++++++++++++++++++++++
util/oslib-posix.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 69 insertions(+)
diff --git a/include/sysemu/os-posix.h b/include/sysemu/os-posix.h
index 9c7dfdf..7630665 100644
--- a/include/sysemu/os-posix.h
+++ b/include/sysemu/os-posix.h
@@ -60,4 +60,27 @@ int qemu_utimens(const char *path, const qemu_timespec *times);
bool is_daemonized(void);
+/**
+ * qemu_alloc_stack:
+ * @sz: size of required stack in bytes
+ *
+ * Allocate memory that can be used as a stack, for instance for
+ * coroutines. If the memory cannot be allocated, this function
+ * will abort (like g_malloc()).
+ *
+ * The allocated stack must be freed with qemu_free_stack().
+ *
+ * Returns: pointer to (the lowest address of) the stack memory.
+ */
+void *qemu_alloc_stack(size_t sz);
+
+/**
+ * qemu_free_stack:
+ * @stack: stack to free
+ * @sz: size of stack in bytes
+ *
+ * Free a stack allocated via qemu_alloc_stack().
+ */
+void qemu_free_stack(void *stack, size_t sz);
+
#endif
diff --git a/util/oslib-posix.c b/util/oslib-posix.c
index e2e1d4d..2303ca6 100644
--- a/util/oslib-posix.c
+++ b/util/oslib-posix.c
@@ -497,3 +497,49 @@ pid_t qemu_fork(Error **errp)
}
return pid;
}
+
+static size_t adjust_stack_size(size_t sz)
+{
+#ifdef _SC_THREAD_STACK_MIN
+ /* avoid stacks smaller than _SC_THREAD_STACK_MIN */
+ sz = MAX(MAX(sysconf(_SC_THREAD_STACK_MIN), 0), sz);
+#endif
+ /* adjust stack size to a multiple of the page size */
+ sz = ROUND_UP(sz, getpagesize());
+ return sz;
+}
+
+void *qemu_alloc_stack(size_t sz)
+{
+ void *ptr, *guardpage;
+ size_t pagesz = getpagesize();
+ sz = adjust_stack_size(sz);
+
+ ptr = mmap(NULL, sz, PROT_READ | PROT_WRITE,
+ MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);
+ if (ptr == MAP_FAILED) {
+ abort();
+ }
+
+#if defined(HOST_IA64)
+ /* separate register stack */
+ guardpage = ptr + (((sz - pagesz) / 2) & ~pagesz);
+#elif defined(HOST_HPPA)
+ /* stack grows up */
+ guardpage = ptr + sz - pagesz;
+#else
+ /* stack grows down */
+ guardpage = ptr;
+#endif
+ if (mprotect(guardpage, pagesz, PROT_NONE) != 0) {
+ abort();
+ }
+
+ return ptr;
+}
+
+void qemu_free_stack(void *stack, size_t sz)
+{
+ sz = adjust_stack_size(sz);
+ munmap(stack, sz);
+}
--
1.9.1
next prev parent reply other threads:[~2016-07-12 16:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 16:23 [Qemu-devel] [PATCH V5 0/6] Peter Lieven
2016-07-12 16:23 ` Peter Lieven [this message]
2016-07-12 17:30 ` [Qemu-devel] [PATCH V5 1/6] oslib-posix: add helpers for stack alloc and free Eric Blake
2016-08-08 10:37 ` Stefan Hajnoczi
2016-08-08 18:29 ` Peter Lieven
2016-08-11 9:05 ` Stefan Hajnoczi
2016-07-12 16:23 ` [Qemu-devel] [PATCH V5 2/6] coroutine: add a macro for the coroutine stack size Peter Lieven
2016-08-08 10:38 ` Stefan Hajnoczi
2016-08-08 10:38 ` Stefan Hajnoczi
2016-07-12 16:23 ` [Qemu-devel] [PATCH V5 3/6] coroutine-ucontext: use helper for allocating stack memory Peter Lieven
2016-08-08 10:39 ` Stefan Hajnoczi
2016-07-12 16:23 ` [Qemu-devel] [PATCH V5 4/6] coroutine-sigaltstack: " Peter Lieven
2016-08-08 10:39 ` Stefan Hajnoczi
2016-07-12 16:23 ` [Qemu-devel] [PATCH V5 5/6] oslib-posix: add a configure switch to debug stack usage Peter Lieven
2016-08-08 10:45 ` Stefan Hajnoczi
2016-07-12 16:23 ` [Qemu-devel] [PATCH V5 6/6] coroutine: reduce stack size to 64kB Peter Lieven
2016-07-12 17:39 ` Eric Blake
2016-08-08 10:45 ` Stefan Hajnoczi
2016-07-27 7:27 ` [Qemu-devel] [PATCH V5 0/6] coroutine: mmap stack memory and stack size Peter Lieven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1468340586-19304-2-git-send-email-pl@kamp.de \
--to=pl@kamp.de \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).