qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Lieven <pl@kamp.de>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, mreitz@redhat.com, pbonzini@redhat.com,
	mst@redhat.com, dgilbert@redhat.com, peter.maydell@linaro.org,
	eblake@redhat.com, rth@twiddle.net, armbru@redhat.com,
	Peter Lieven <pl@kamp.de>
Subject: [Qemu-devel] [PATCH V5 3/6] coroutine-ucontext: use helper for allocating stack memory
Date: Tue, 12 Jul 2016 18:23:03 +0200	[thread overview]
Message-ID: <1468340586-19304-4-git-send-email-pl@kamp.de> (raw)
In-Reply-To: <1468340586-19304-1-git-send-email-pl@kamp.de>

Reviewed-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Peter Lieven <pl@kamp.de>
---
 util/coroutine-ucontext.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/util/coroutine-ucontext.c b/util/coroutine-ucontext.c
index 31254ab..b7dea8c 100644
--- a/util/coroutine-ucontext.c
+++ b/util/coroutine-ucontext.c
@@ -82,7 +82,6 @@ static void coroutine_trampoline(int i0, int i1)
 
 Coroutine *qemu_coroutine_new(void)
 {
-    const size_t stack_size = COROUTINE_STACK_SIZE;
     CoroutineUContext *co;
     ucontext_t old_uc, uc;
     sigjmp_buf old_env;
@@ -101,17 +100,17 @@ Coroutine *qemu_coroutine_new(void)
     }
 
     co = g_malloc0(sizeof(*co));
-    co->stack = g_malloc(stack_size);
+    co->stack = qemu_alloc_stack(COROUTINE_STACK_SIZE);
     co->base.entry_arg = &old_env; /* stash away our jmp_buf */
 
     uc.uc_link = &old_uc;
     uc.uc_stack.ss_sp = co->stack;
-    uc.uc_stack.ss_size = stack_size;
+    uc.uc_stack.ss_size = COROUTINE_STACK_SIZE;
     uc.uc_stack.ss_flags = 0;
 
 #ifdef CONFIG_VALGRIND_H
     co->valgrind_stack_id =
-        VALGRIND_STACK_REGISTER(co->stack, co->stack + stack_size);
+        VALGRIND_STACK_REGISTER(co->stack, co->stack + COROUTINE_STACK_SIZE);
 #endif
 
     arg.p = co;
@@ -149,7 +148,7 @@ void qemu_coroutine_delete(Coroutine *co_)
     valgrind_stack_deregister(co);
 #endif
 
-    g_free(co->stack);
+    qemu_free_stack(co->stack, COROUTINE_STACK_SIZE);
     g_free(co);
 }
 
-- 
1.9.1

  parent reply	other threads:[~2016-07-12 16:23 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-12 16:23 [Qemu-devel] [PATCH V5 0/6] Peter Lieven
2016-07-12 16:23 ` [Qemu-devel] [PATCH V5 1/6] oslib-posix: add helpers for stack alloc and free Peter Lieven
2016-07-12 17:30   ` Eric Blake
2016-08-08 10:37   ` Stefan Hajnoczi
2016-08-08 18:29     ` Peter Lieven
2016-08-11  9:05       ` Stefan Hajnoczi
2016-07-12 16:23 ` [Qemu-devel] [PATCH V5 2/6] coroutine: add a macro for the coroutine stack size Peter Lieven
2016-08-08 10:38   ` Stefan Hajnoczi
2016-08-08 10:38   ` Stefan Hajnoczi
2016-07-12 16:23 ` Peter Lieven [this message]
2016-08-08 10:39   ` [Qemu-devel] [PATCH V5 3/6] coroutine-ucontext: use helper for allocating stack memory Stefan Hajnoczi
2016-07-12 16:23 ` [Qemu-devel] [PATCH V5 4/6] coroutine-sigaltstack: " Peter Lieven
2016-08-08 10:39   ` Stefan Hajnoczi
2016-07-12 16:23 ` [Qemu-devel] [PATCH V5 5/6] oslib-posix: add a configure switch to debug stack usage Peter Lieven
2016-08-08 10:45   ` Stefan Hajnoczi
2016-07-12 16:23 ` [Qemu-devel] [PATCH V5 6/6] coroutine: reduce stack size to 64kB Peter Lieven
2016-07-12 17:39   ` Eric Blake
2016-08-08 10:45   ` Stefan Hajnoczi
2016-07-27  7:27 ` [Qemu-devel] [PATCH V5 0/6] coroutine: mmap stack memory and stack size Peter Lieven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1468340586-19304-4-git-send-email-pl@kamp.de \
    --to=pl@kamp.de \
    --cc=armbru@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=eblake@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).