From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44466) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNCQu-0001PG-53 for qemu-devel@nongnu.org; Wed, 13 Jul 2016 01:10:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNCQo-0004SO-4q for qemu-devel@nongnu.org; Wed, 13 Jul 2016 01:10:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50289) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNCQn-0004SE-VR for qemu-devel@nongnu.org; Wed, 13 Jul 2016 01:09:58 -0400 From: Fam Zheng Date: Wed, 13 Jul 2016 13:09:42 +0800 Message-Id: <1468386588-26584-1-git-send-email-famz@redhat.com> Subject: [Qemu-devel] [PATCH v4 0/6] virtio: Merge virtio-{blk, scsi} host notifier handling paths List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: cornelia.huck@de.ibm.com, kwolf@redhat.com, pbonzini@redhat.com, stefanha@redhat.com, mst@redhat.com v4: Drop patch 1. [Cornelia] Add the last trivial patch. v3: Rebase to master. Squash 4 into 3. [Paolo] Add comment and commit message. [Stefan] Add Stefan's r-b in patch 1 and 2. v2: Only convert virtio-{blk,scsi}. [Paolo] The benifit of this is we don't use event_notifier_set_handler even in non-dataplane now, which in turn makes virtio-blk and virtio-scsi follow block layer aio context semantics. Specifically, I/O requests must come from blk_get_aio_context(blk) events, rather than iohandler_get_aio_context(), so that bdrv_drained_begin/end will work as expected. Patch 4 reverts the hack (ab27c3b5e7) we added for 2.6. Lately, commit b880481579 added another pair of bdrv_drained_begin/end so the crash cannot happen even without ab27c3b5e7, but in order to avoid leaking requests, patch two is still a must. Fam Zheng (6): virtio: Add typedef for handle_output virtio: Introduce virtio_add_queue_aio virtio-blk: Call virtio_add_queue_aio virtio-scsi: Call virtio_add_queue_aio Revert "mirror: Workaround for unexpected iohandler events during completion" virtio-scsi: Replace HandleOutput typedef block/mirror.c | 9 --------- hw/block/virtio-blk.c | 2 +- hw/scsi/virtio-scsi.c | 14 ++++++------- hw/virtio/virtio.c | 45 +++++++++++++++++++++++++++++++++-------- include/hw/virtio/virtio-scsi.h | 6 ++---- include/hw/virtio/virtio.h | 8 ++++++-- 6 files changed, 52 insertions(+), 32 deletions(-) -- 2.7.4