From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [Qemu-devel] [PULL 07/14] qemu-sockets: use qapi_free_SocketAddress in cleanup
Date: Wed, 13 Jul 2016 15:26:25 +0200 [thread overview]
Message-ID: <1468416392-120170-8-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1468416392-120170-1-git-send-email-pbonzini@redhat.com>
From: Marc-André Lureau <marcandre.lureau@redhat.com>
Commit 74b6ce43e3 uses the wrong free API for a SocketAddress, that
may leak some linked data.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20160706164246.22116-1-marcandre.lureau@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
util/qemu-sockets.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c
index fb83d48..777af49 100644
--- a/util/qemu-sockets.c
+++ b/util/qemu-sockets.c
@@ -1012,7 +1012,7 @@ void socket_listen_cleanup(int fd, Error **errp)
}
}
- g_free(addr);
+ qapi_free_SocketAddress(addr);
}
int socket_dgram(SocketAddress *remote, SocketAddress *local, Error **errp)
--
1.8.3.1
next prev parent reply other threads:[~2016-07-13 13:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-13 13:26 [Qemu-devel] [PULL 00/14] SCSI, chardev, build fixes for 2016-07-13 Paolo Bonzini
2016-07-13 13:26 ` [Qemu-devel] [PULL 01/14] scsi-bus: Add SCSI scanner support Paolo Bonzini
2016-07-13 13:26 ` [Qemu-devel] [PULL 02/14] scsi-bus: Use longer sense buffer with scanners Paolo Bonzini
2016-07-13 13:26 ` [Qemu-devel] [PULL 03/14] Use "-s" instead of "--quiet" to resolve non-fatal build error on FreeBSD Paolo Bonzini
2016-07-13 13:26 ` [Qemu-devel] [PULL 04/14] main-loop: check return value before using pointer Paolo Bonzini
2016-07-13 13:26 ` [Qemu-devel] [PULL 05/14] json-streamer: fix double-free on exiting during a parse Paolo Bonzini
2016-07-13 13:26 ` [Qemu-devel] [PULL 06/14] disas: avoid including everything in headers compiled from C++ Paolo Bonzini
2016-07-13 13:26 ` Paolo Bonzini [this message]
2016-07-13 13:26 ` [Qemu-devel] [PULL 08/14] util: Fix MIN_NON_ZERO Paolo Bonzini
2016-07-13 13:26 ` [Qemu-devel] [PULL 09/14] tap: use an exit notifier to call down_script Paolo Bonzini
2016-07-13 13:26 ` [Qemu-devel] [PULL 10/14] slirp: use exit notifier for slirp_smb_cleanup Paolo Bonzini
2016-07-13 13:26 ` [Qemu-devel] [PULL 11/14] net: do not use atexit for cleanup Paolo Bonzini
2016-07-13 13:26 ` [Qemu-devel] [PULL 12/14] char: do not use atexit cleanup handler Paolo Bonzini
2016-07-13 13:26 ` [Qemu-devel] [PULL 13/14] hostmem: fix QEMU crash by 'info memdev' Paolo Bonzini
2016-07-13 13:26 ` [Qemu-devel] [PULL 14/14] hostmem: detect host backend memory is being used properly Paolo Bonzini
2016-07-14 14:57 ` [Qemu-devel] [PULL 00/14] SCSI, chardev, build fixes for 2016-07-13 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1468416392-120170-8-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).