From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51604) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNggp-0000hn-I6 for qemu-devel@nongnu.org; Thu, 14 Jul 2016 09:28:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNggn-0006Qv-FI for qemu-devel@nongnu.org; Thu, 14 Jul 2016 09:28:30 -0400 From: Kevin Wolf Date: Thu, 14 Jul 2016 15:28:03 +0200 Message-Id: <1468502894-18098-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH v4 00/11] block: Accept node-name in all node level QMP commands List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: kwolf@redhat.com, mreitz@redhat.com, eblake@redhat.com, berto@igalia.com, qemu-devel@nongnu.org As stated in the RFC I sent two weeks ago: * Node level commands: We need to complete the conversion that makes commands accept node names instead of BlockBackend names. In some places we intentionally allow only BlockBackends because we don't know if the command works in other places than the root. This is okay, but we can accept node names anyway. We just need to check that the node is a root node as expected. This part of the RFC is implemented by this series. v4: - Changed the way to decide whether a root-node-only QMP command is allowed on a specific node. Instead of checking that it has a BB on top, the new check is that there is no non-BB parent on top. This allows using unattached nodes. - Fixed incorrect documentation change for block-commit [Eric] v3: - Now with updated documentation Kevin Wolf (11): block: Accept node-name for block-stream block: Accept node-name for block-commit block: Accept node-name for blockdev-backup block: Accept node-name for blockdev-mirror block: Accept node-name for blockdev-snapshot-delete-internal-sync block: Accept node-name for blockdev-snapshot-internal-sync block: Accept node-name for change-backing-file block: Accept node-name for drive-backup block: Accept node-name for drive-mirror nbd-server: Use a separate BlockBackend nbd-server: Allow node name for nbd-server-add block.c | 2 + block/block-backend.c | 16 ++++ blockdev-nbd.c | 21 ++--- blockdev.c | 196 +++++++++++++---------------------------- include/block/nbd.h | 3 +- include/sysemu/block-backend.h | 1 + nbd/server.c | 25 ++++-- qapi/block-core.json | 24 ++--- qapi/block.json | 14 +-- qemu-nbd.c | 4 +- qmp-commands.hx | 25 +++--- tests/qemu-iotests/030 | 2 +- tests/qemu-iotests/041 | 8 +- tests/qemu-iotests/055 | 7 +- tests/qemu-iotests/057 | 4 +- 15 files changed, 158 insertions(+), 194 deletions(-) -- 1.8.3.1