qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Denis V. Lunev" <den@openvz.org>
To: qemu-block@nongnu.org, qemu-devel@nongnu.org
Cc: den@openvz.org, Stefan Hajnoczi <stefanha@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>,
	Jeff Cody <jcody@redhat.com>
Subject: [Qemu-devel] [PATCH v3 5/8] block: remove extra condition in bdrv_can_write_zeroes_with_unmap
Date: Thu, 14 Jul 2016 16:33:26 +0300	[thread overview]
Message-ID: <1468503209-19498-6-git-send-email-den@openvz.org> (raw)
In-Reply-To: <1468503209-19498-1-git-send-email-den@openvz.org>

All .bdrv_co_write_zeroes callbacks nowadays work perfectly even
with backing store attached. If future new callbacks would be unable to do
that - they have a chance to block this in bdrv_get_info().

Signed-off-by: Denis V. Lunev <den@openvz.org>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
CC: Stefan Hajnoczi <stefanha@redhat.com>
CC: Kevin Wolf <kwolf@redhat.com>
CC: Max Reitz <mreitz@redhat.com>
CC: Jeff Cody <jcody@redhat.com>
---
 block.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block.c b/block.c
index 823ff1d..c2fb8bd 100644
--- a/block.c
+++ b/block.c
@@ -2834,7 +2834,7 @@ bool bdrv_can_write_zeroes_with_unmap(BlockDriverState *bs)
 {
     BlockDriverInfo bdi;
 
-    if (bs->backing || !(bs->open_flags & BDRV_O_UNMAP)) {
+    if (!(bs->open_flags & BDRV_O_UNMAP)) {
         return false;
     }
 
-- 
2.5.0

  parent reply	other threads:[~2016-07-14 13:33 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-14 13:33 [Qemu-devel] [PATCH v3 0/8] drive-mirror improvements Denis V. Lunev
2016-07-14 13:33 ` [Qemu-devel] [PATCH v3 1/8] dirty-bitmap: operate with int64_t amount Denis V. Lunev
2016-07-14 13:33 ` [Qemu-devel] [PATCH v3 2/8] mirror: make sectors_in_flight int64_t Denis V. Lunev
2016-07-14 13:33 ` [Qemu-devel] [PATCH v3 3/8] mirror: create mirror_throttle helper Denis V. Lunev
2016-07-14 15:21   ` Eric Blake
2016-07-14 13:33 ` [Qemu-devel] [PATCH v3 4/8] mirror: create mirror_dirty_init helper for mirror_run Denis V. Lunev
2016-07-14 16:19   ` Eric Blake
2016-07-14 16:48     ` Denis V. Lunev
2016-07-14 13:33 ` Denis V. Lunev [this message]
2016-07-14 13:33 ` [Qemu-devel] [PATCH v3 6/8] mirror: optimize dirty bitmap filling in mirror_run a bit Denis V. Lunev
2016-07-14 13:33 ` [Qemu-devel] [PATCH v3 7/8] mirror: efficiently zero out target Denis V. Lunev
2016-07-14 13:33 ` [Qemu-devel] [PATCH v3 8/8] mirror: improve performance of mirroring of empty disk Denis V. Lunev
2016-07-18 15:37 ` [Qemu-devel] [PATCH v3 0/8] drive-mirror improvements Denis V. Lunev
2016-07-19  8:43   ` Stefan Hajnoczi
2016-07-19 21:07 ` Jeff Cody

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1468503209-19498-6-git-send-email-den@openvz.org \
    --to=den@openvz.org \
    --cc=jcody@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).