qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, mreitz@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 2/2] scsi: scsi-cd without drive property for empty drive
Date: Thu, 14 Jul 2016 15:49:43 +0200	[thread overview]
Message-ID: <1468504183-20180-3-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1468504183-20180-1-git-send-email-kwolf@redhat.com>

This allows to create an empty scsi-cd device without manually creating
a BlockBackend.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 hw/scsi/scsi-disk.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
index 8dbfc10..b4e71ff 100644
--- a/hw/scsi/scsi-disk.c
+++ b/hw/scsi/scsi-disk.c
@@ -2359,6 +2359,11 @@ static void scsi_hd_realize(SCSIDevice *dev, Error **errp)
 static void scsi_cd_realize(SCSIDevice *dev, Error **errp)
 {
     SCSIDiskState *s = DO_UPCAST(SCSIDiskState, qdev, dev);
+
+    if (!dev->conf.blk) {
+        dev->conf.blk = blk_new();
+    }
+
     s->qdev.blocksize = 2048;
     s->qdev.type = TYPE_ROM;
     s->features |= 1 << SCSI_DISK_F_REMOVABLE;
-- 
1.8.3.1

  parent reply	other threads:[~2016-07-14 13:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-14 13:49 [Qemu-devel] [PATCH 0/2] block: Create empty drives without explicit BB Kevin Wolf
2016-07-14 13:49 ` [Qemu-devel] [PATCH 1/2] ide: ide-cd without drive property for empty drive Kevin Wolf
2016-07-14 19:48   ` Eric Blake
2016-08-01 19:47     ` Kevin Wolf
2016-08-04 16:03       ` Eric Blake
2016-08-05 10:34         ` Kevin Wolf
2016-07-14 13:49 ` Kevin Wolf [this message]
2016-07-14 19:49   ` [Qemu-devel] [PATCH 2/2] scsi: scsi-cd " Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1468504183-20180-3-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).