From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58045) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNjub-0002x0-1a for qemu-devel@nongnu.org; Thu, 14 Jul 2016 12:54:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNjua-00008Z-1E for qemu-devel@nongnu.org; Thu, 14 Jul 2016 12:54:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51787) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNjuZ-00008E-SC for qemu-devel@nongnu.org; Thu, 14 Jul 2016 12:54:55 -0400 From: Igor Mammedov Date: Thu, 14 Jul 2016 18:54:33 +0200 Message-Id: <1468515285-173356-5-git-send-email-imammedo@redhat.com> In-Reply-To: <1468515285-173356-1-git-send-email-imammedo@redhat.com> References: <1468515285-173356-1-git-send-email-imammedo@redhat.com> Subject: [Qemu-devel] [PATCH v4 04/16] pc: forbid BSP removal List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pkrempa@redhat.com, ehabkost@redhat.com, mst@redhat.com, eduardo.otubo@profitbricks.com, Bandan Das BSP is assumed to always present in QEMU code, so untile that assumptions are gone, deny removal request. In another words QEMU won't support BSP hot-unplug. Signed-off-by: Igor Mammedov --- hw/i386/pc.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 5a67f15..33c5f97 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -1751,10 +1751,17 @@ out: static void pc_cpu_unplug_request_cb(HotplugHandler *hotplug_dev, DeviceState *dev, Error **errp) { + int idx; HotplugHandlerClass *hhc; Error *local_err = NULL; PCMachineState *pcms = PC_MACHINE(hotplug_dev); + pc_find_cpu_slot(pcms, CPU(dev), &idx); + if (idx == 0) { + error_setg(&local_err, "1st CPU (BSP) is unpluggable"); + goto out; + } + hhc = HOTPLUG_HANDLER_GET_CLASS(pcms->acpi_dev); hhc->unplug_request(HOTPLUG_HANDLER(pcms->acpi_dev), dev, &local_err); -- 2.7.4