From: Colin Lord <clord@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, qemu-block@nongnu.org, mreitz@redhat.com,
Colin Lord <clord@redhat.com>
Subject: [Qemu-devel] [PATCH v4 12/32] blockdev: Move raw probe to its own file
Date: Thu, 14 Jul 2016 15:03:08 -0400 [thread overview]
Message-ID: <1468523008-30013-13-git-send-email-clord@redhat.com> (raw)
In-Reply-To: <1468523008-30013-1-git-send-email-clord@redhat.com>
Isolate raw probe as part of the modularization process.
Signed-off-by: Colin Lord <clord@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
---
block/Makefile.objs | 1 +
block/raw-probe.c | 10 ++++++++++
block/raw_bsd.c | 9 +--------
include/block/probe.h | 1 +
4 files changed, 13 insertions(+), 8 deletions(-)
create mode 100644 block/raw-probe.c
diff --git a/block/Makefile.objs b/block/Makefile.objs
index db9faef..07b0a2d 100644
--- a/block/Makefile.objs
+++ b/block/Makefile.objs
@@ -26,6 +26,7 @@ block-obj-y += write-threshold.o
block-obj-y += crypto.o
block-obj-y += bochs-probe.o cloop-probe.o crypto-probe.o dmg-probe.o
block-obj-y += parallels-probe.o qcow-probe.o qcow2-probe.o qed-probe.o
+block-obj-y += raw-probe.o
common-obj-y += stream.o
common-obj-y += backup.o
diff --git a/block/raw-probe.c b/block/raw-probe.c
new file mode 100644
index 0000000..22c6bcb
--- /dev/null
+++ b/block/raw-probe.c
@@ -0,0 +1,10 @@
+#include "qemu/osdep.h"
+#include "block/probe.h"
+
+int raw_probe(const uint8_t *buf, int buf_size, const char *filename)
+{
+ /* smallest possible positive score so that raw is used if and only if no
+ * other block driver works
+ */
+ return 1;
+}
diff --git a/block/raw_bsd.c b/block/raw_bsd.c
index 5f9dd29..25d5185 100644
--- a/block/raw_bsd.c
+++ b/block/raw_bsd.c
@@ -28,6 +28,7 @@
#include "qemu/osdep.h"
#include "block/block_int.h"
+#include "block/probe.h"
#include "qapi/error.h"
#include "qemu/option.h"
@@ -213,14 +214,6 @@ static void raw_close(BlockDriverState *bs)
{
}
-static int raw_probe(const uint8_t *buf, int buf_size, const char *filename)
-{
- /* smallest possible positive score so that raw is used if and only if no
- * other block driver works
- */
- return 1;
-}
-
static int raw_probe_blocksizes(BlockDriverState *bs, BlockSizes *bsz)
{
return bdrv_probe_blocksizes(bs->file->bs, bsz);
diff --git a/include/block/probe.h b/include/block/probe.h
index e3e9934..053f961 100644
--- a/include/block/probe.h
+++ b/include/block/probe.h
@@ -10,5 +10,6 @@ int parallels_probe(const uint8_t *buf, int buf_size, const char *filename);
int qcow_probe(const uint8_t *buf, int buf_size, const char *filename);
int qcow2_probe(const uint8_t *buf, int buf_size, const char *filename);
int bdrv_qed_probe(const uint8_t *buf, int buf_size, const char *filename);
+int raw_probe(const uint8_t *buf, int buf_size, const char *filename);
#endif
--
2.5.5
next prev parent reply other threads:[~2016-07-14 19:03 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 19:02 [Qemu-devel] [PATCH v4 00/32] Dynamic module loading for block drivers Colin Lord
2016-07-14 19:02 ` [Qemu-devel] [PATCH v4 01/32] blockdev: prepare iSCSI block driver for dynamic loading Colin Lord
2016-07-14 19:02 ` [Qemu-devel] [PATCH v4 02/32] blockdev: Add dynamic generation of module_block.h Colin Lord
2016-07-14 19:02 ` [Qemu-devel] [PATCH v4 03/32] blockdev: Add dynamic module loading for block drivers Colin Lord
2016-07-14 19:03 ` [Qemu-devel] [PATCH v4 04/32] blockdev: Move bochs probe into separate file Colin Lord
2016-07-14 19:03 ` [Qemu-devel] [PATCH v4 05/32] blockdev: Move cloop probe to its own file Colin Lord
2016-07-14 19:03 ` [Qemu-devel] [PATCH v4 06/32] blockdev: Move luks " Colin Lord
2016-07-14 19:03 ` [Qemu-devel] [PATCH v4 07/32] blockdev: Move dmg " Colin Lord
2016-07-14 19:03 ` [Qemu-devel] [PATCH v4 08/32] blockdev: Move parallels " Colin Lord
2016-07-14 19:03 ` [Qemu-devel] [PATCH v4 09/32] blockdev: Move qcow " Colin Lord
2016-07-14 19:03 ` [Qemu-devel] [PATCH v4 10/32] blockdev: Move qcow2 " Colin Lord
2016-07-14 19:03 ` [Qemu-devel] [PATCH v4 11/32] blockdev: Move qed " Colin Lord
2016-07-14 19:03 ` Colin Lord [this message]
2016-07-14 19:03 ` [Qemu-devel] [PATCH v4 13/32] blockdev: Move vdi " Colin Lord
2016-07-14 19:03 ` [Qemu-devel] [PATCH v4 14/32] blockdev: Move vhdx " Colin Lord
2016-07-14 19:03 ` [Qemu-devel] [PATCH v4 15/32] blockdev: Move vmdk " Colin Lord
2016-07-14 19:03 ` [Qemu-devel] [PATCH v4 16/32] blockdev: Move vpc " Colin Lord
2016-07-14 19:03 ` [Qemu-devel] [PATCH v4 17/32] blockdev: Separate bochs probe from its driver Colin Lord
2016-07-18 16:28 ` Max Reitz
2016-07-18 19:44 ` Colin Lord
2016-07-14 19:03 ` [Qemu-devel] [PATCH v4 18/32] blockdev: Separate cloop " Colin Lord
2016-07-14 19:03 ` [Qemu-devel] [PATCH v4 19/32] blockdev: Separate luks " Colin Lord
2016-07-14 19:03 ` [Qemu-devel] [PATCH v4 20/32] blockdev: Separate dmg " Colin Lord
2016-07-14 19:03 ` [Qemu-devel] [PATCH v4 21/32] blockdev: Separate parallels " Colin Lord
2016-07-14 19:03 ` [Qemu-devel] [PATCH v4 22/32] blockdev: Separate qcow " Colin Lord
2016-07-14 19:03 ` [Qemu-devel] [PATCH v4 23/32] blockdev: Separate qcow2 " Colin Lord
2016-07-14 19:03 ` [Qemu-devel] [PATCH v4 24/32] blockdev: Separate qed " Colin Lord
2016-07-14 19:03 ` [Qemu-devel] [PATCH v4 25/32] blockdev: Separate raw " Colin Lord
2016-07-14 19:03 ` [Qemu-devel] [PATCH v4 26/32] blockdev: Separate vdi " Colin Lord
2016-07-14 19:03 ` [Qemu-devel] [PATCH v4 27/32] blockdev: Separate vhdx " Colin Lord
2016-07-14 19:03 ` [Qemu-devel] [PATCH v4 28/32] blockdev: Separate vmdk " Colin Lord
2016-07-14 19:03 ` [Qemu-devel] [PATCH v4 29/32] blockdev: Separate vpc " Colin Lord
2016-07-14 19:03 ` [Qemu-devel] [PATCH v4 30/32] blockdev: Remove the .bdrv_probe field from BlockDrivers Colin Lord
2016-07-14 19:03 ` [Qemu-devel] [PATCH v4 31/32] blockdev: Separate out bdrv_probe_device functions Colin Lord
2016-07-14 19:03 ` [Qemu-devel] [PATCH v4 32/32] blockdev: Remove bdrv_probe_device field from BlockDriver Colin Lord
2016-07-19 10:54 ` [Qemu-devel] [PATCH v4 00/32] Dynamic module loading for block drivers Paolo Bonzini
2016-07-19 13:47 ` Colin Lord
2016-07-19 14:42 ` Paolo Bonzini
2016-07-19 15:06 ` Daniel P. Berrange
2016-07-22 16:27 ` Max Reitz
2016-07-22 16:40 ` Paolo Bonzini
2016-07-22 16:43 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1468523008-30013-13-git-send-email-clord@redhat.com \
--to=clord@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).