From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39411)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1bO057-0005a2-9x
	for qemu-devel@nongnu.org; Fri, 15 Jul 2016 06:10:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1bO054-0001Ja-1n
	for qemu-devel@nongnu.org; Fri, 15 Jul 2016 06:10:53 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58675)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1bO053-0001JQ-St
	for qemu-devel@nongnu.org; Fri, 15 Jul 2016 06:10:49 -0400
Message-ID: <1468577447.22036.7.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Fri, 15 Jul 2016 12:10:47 +0200
In-Reply-To: <5784B8EB.7010008@huawei.com>
References: <5784B8EB.7010008@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] vnc-enc-tight: fix off-by-one bug
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Herongguang (Stephen)" <herongguang.he@huawei.com>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, weidong.huang@huawei.com, "peter.huangpeng@huawei.com >> Huangpeng (Peter)" <peter.huangpeng@huawei.com>

On Di, 2016-07-12 at 17:31 +0800, Herongguang (Stephen) wrote:
> In tight_encode_indexed_rect32, buf(or src)=E2=80=99s size is count. In f=
or loop,
> the logic is supposed to be that i is an index into src, i should be
> incremented when incrementing src.
>=20
> This is broken when src is incremented but i is not before while loop,
> resulting in off-by-one bug in while loop.
>=20
> Signed-off-by: He Rongguang <herongguang.he@huawei.com>

Added to vnc queue.

Patch is whitespace mangled, had to use "patch --ignore-whitespace" to
get it applied.  Can you please use 'git send-email' to send patches in
the future?  That is the best way to avoid your mail client breaking
patches.

thanks,
  Gerd