From: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
To: qemu-devel@nongnu.org
Cc: eblake@redhat.com, armbru@redhat.com, jcody@redhat.com,
berrange@redhat.com, vbellur@redhat.com, rtalur@redhat.com,
Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Subject: [Qemu-devel] [PATCH v19 3/5] block/gluster: remove rdma transport
Date: Fri, 15 Jul 2016 20:30:56 +0530 [thread overview]
Message-ID: <1468594858-26889-4-git-send-email-prasanna.kalever@redhat.com> (raw)
In-Reply-To: <1468594858-26889-1-git-send-email-prasanna.kalever@redhat.com>
gluster volfile server fetch happens through unix and/or tcp, it doesn't
support volfile fetch over rdma, hence removing the dead code
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
---
block/gluster.c | 35 +----------------------------------
1 file changed, 1 insertion(+), 34 deletions(-)
diff --git a/block/gluster.c b/block/gluster.c
index 40ee852..59f77bb 100644
--- a/block/gluster.c
+++ b/block/gluster.c
@@ -134,8 +134,7 @@ static int parse_volume_options(GlusterConf *gconf, char *path)
*
* 'transport' specifies the transport type used to connect to gluster
* management daemon (glusterd). Valid transport types are
- * tcp, unix and rdma. If a transport type isn't specified, then tcp
- * type is assumed.
+ * tcp, unix. If a transport type isn't specified, then tcp type is assumed.
*
* 'host' specifies the host where the volume file specification for
* the given volume resides. This can be either hostname, ipv4 address
@@ -162,7 +161,6 @@ static int parse_volume_options(GlusterConf *gconf, char *path)
* file=gluster+tcp://[1:2:3:4:5:6:7:8]:24007/testvol/dir/a.img
* file=gluster+tcp://host.domain.com:24007/testvol/dir/a.img
* file=gluster+unix:///testvol/dir/a.img?socket=/tmp/glusterd.socket
- * file=gluster+rdma://1.2.3.4:24007/testvol/a.img
*/
static int qemu_gluster_parseuri(GlusterConf *gconf, const char *filename)
{
@@ -184,8 +182,6 @@ static int qemu_gluster_parseuri(GlusterConf *gconf, const char *filename)
} else if (!strcmp(uri->scheme, "gluster+unix")) {
gconf->transport = g_strdup("unix");
is_unix = true;
- } else if (!strcmp(uri->scheme, "gluster+rdma")) {
- gconf->transport = g_strdup("rdma");
} else {
ret = -EINVAL;
goto out;
@@ -1048,37 +1044,8 @@ static BlockDriver bdrv_gluster_unix = {
.create_opts = &qemu_gluster_create_opts,
};
-static BlockDriver bdrv_gluster_rdma = {
- .format_name = "gluster",
- .protocol_name = "gluster+rdma",
- .instance_size = sizeof(BDRVGlusterState),
- .bdrv_needs_filename = true,
- .bdrv_file_open = qemu_gluster_open,
- .bdrv_reopen_prepare = qemu_gluster_reopen_prepare,
- .bdrv_reopen_commit = qemu_gluster_reopen_commit,
- .bdrv_reopen_abort = qemu_gluster_reopen_abort,
- .bdrv_close = qemu_gluster_close,
- .bdrv_create = qemu_gluster_create,
- .bdrv_getlength = qemu_gluster_getlength,
- .bdrv_get_allocated_file_size = qemu_gluster_allocated_file_size,
- .bdrv_truncate = qemu_gluster_truncate,
- .bdrv_co_readv = qemu_gluster_co_readv,
- .bdrv_co_writev = qemu_gluster_co_writev,
- .bdrv_co_flush_to_disk = qemu_gluster_co_flush_to_disk,
- .bdrv_has_zero_init = qemu_gluster_has_zero_init,
-#ifdef CONFIG_GLUSTERFS_DISCARD
- .bdrv_co_discard = qemu_gluster_co_discard,
-#endif
-#ifdef CONFIG_GLUSTERFS_ZEROFILL
- .bdrv_co_pwrite_zeroes = qemu_gluster_co_pwrite_zeroes,
-#endif
- .bdrv_co_get_block_status = qemu_gluster_co_get_block_status,
- .create_opts = &qemu_gluster_create_opts,
-};
-
static void bdrv_gluster_init(void)
{
- bdrv_register(&bdrv_gluster_rdma);
bdrv_register(&bdrv_gluster_unix);
bdrv_register(&bdrv_gluster_tcp);
bdrv_register(&bdrv_gluster);
--
2.7.4
next prev parent reply other threads:[~2016-07-15 15:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 15:00 [Qemu-devel] [PATCH v19 0/5] block/gluster: add support for multiple gluster servers Prasanna Kumar Kalever
2016-07-15 15:00 ` [Qemu-devel] [PATCH v19 1/5] block/gluster: rename [server, volname, image] -> [host, volume, path] Prasanna Kumar Kalever
2016-07-15 15:00 ` [Qemu-devel] [PATCH v19 2/5] block/gluster: code cleanup Prasanna Kumar Kalever
2016-07-15 15:00 ` Prasanna Kumar Kalever [this message]
2016-07-18 8:53 ` [Qemu-devel] [PATCH v19 3/5] block/gluster: remove rdma transport Markus Armbruster
2016-07-18 11:12 ` Prasanna Kalever
2016-07-18 12:18 ` Markus Armbruster
2016-07-18 13:35 ` Raghavendra Talur
2016-07-18 13:50 ` Prasanna Kalever
2016-07-18 14:02 ` Markus Armbruster
2016-07-15 15:00 ` [Qemu-devel] [PATCH v19 4/5] block/gluster: using new qapi schema Prasanna Kumar Kalever
2016-07-18 9:29 ` Markus Armbruster
2016-07-18 11:29 ` Prasanna Kalever
2016-07-18 13:11 ` Markus Armbruster
2016-07-18 18:28 ` Prasanna Kalever
2016-07-19 11:12 ` Markus Armbruster
2016-07-19 12:57 ` Eric Blake
2016-07-19 14:29 ` Markus Armbruster
2016-07-15 15:00 ` [Qemu-devel] [PATCH v19 5/5] block/gluster: add support for multiple gluster servers Prasanna Kumar Kalever
2016-07-18 10:17 ` Markus Armbruster
2016-07-18 11:51 ` Prasanna Kalever
2016-07-18 14:39 ` Markus Armbruster
2016-07-18 19:02 ` Prasanna Kalever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1468594858-26889-4-git-send-email-prasanna.kalever@redhat.com \
--to=prasanna.kalever@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=jcody@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rtalur@redhat.com \
--cc=vbellur@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).