qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: qemu-block@nongnu.org
Cc: vsementsov@virtuozzo.com, famz@redhat.com, qemu-devel@nongnu.org,
	mreitz@redhat.com, John Snow <jsnow@redhat.com>
Subject: [Qemu-devel] [PATCH v6 06/10] block: Assert that bdrv_release_dirty_bitmap succeeded
Date: Fri, 15 Jul 2016 16:27:37 -0400	[thread overview]
Message-ID: <1468614461-28807-7-git-send-email-jsnow@redhat.com> (raw)
In-Reply-To: <1468614461-28807-1-git-send-email-jsnow@redhat.com>

From: Fam Zheng <famz@redhat.com>

We use a loop over bs->dirty_bitmaps to make sure the caller is
only releasing a bitmap owned by bs. Let's also assert that in this case
the caller is releasing a bitmap that does exist.

Signed-off-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: John Snow <jsnow@redhat.com>
---
 block/dirty-bitmap.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c
index a71c9b7..39e072a 100644
--- a/block/dirty-bitmap.c
+++ b/block/dirty-bitmap.c
@@ -305,6 +305,9 @@ static void bdrv_do_release_matching_dirty_bitmap(BlockDriverState *bs,
             }
         }
     }
+    if (bitmap) {
+        abort();
+    }
 }
 
 void bdrv_release_dirty_bitmap(BlockDriverState *bs, BdrvDirtyBitmap *bitmap)
-- 
2.7.4

  parent reply	other threads:[~2016-07-15 20:27 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-15 20:27 [Qemu-devel] [PATCH v6 00/10] Dirty bitmap changes for migration/persistence work John Snow
2016-07-15 20:27 ` [Qemu-devel] [PATCH v6 01/10] block: Hide HBitmap in block dirty bitmap interface John Snow
2016-07-15 20:27 ` [Qemu-devel] [PATCH v6 02/10] HBitmap: Introduce "meta" bitmap to track bit changes John Snow
2016-07-18 14:54   ` Max Reitz
2016-07-15 20:27 ` [Qemu-devel] [PATCH v6 03/10] tests: Add test code for meta bitmap John Snow
2016-07-15 20:27 ` [Qemu-devel] [PATCH v6 04/10] block: Support meta dirty bitmap John Snow
2016-07-18 14:57   ` Max Reitz
2016-07-18 16:24     ` John Snow
2016-07-15 20:27 ` [Qemu-devel] [PATCH v6 05/10] block: Add two dirty bitmap getters John Snow
2016-07-15 20:27 ` John Snow [this message]
2016-07-15 20:27 ` [Qemu-devel] [PATCH v6 07/10] hbitmap: serialization John Snow
2016-07-15 20:27 ` [Qemu-devel] [PATCH v6 08/10] block: BdrvDirtyBitmap serialization interface John Snow
2016-07-18 15:11   ` Max Reitz
2016-07-15 20:27 ` [Qemu-devel] [PATCH v6 09/10] tests: Add test code for hbitmap serialization John Snow
2016-07-18 15:24   ` Max Reitz
2016-07-18 19:45     ` John Snow
2016-07-15 20:27 ` [Qemu-devel] [PATCH v6 10/10] block: More operations for meta dirty bitmap John Snow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1468614461-28807-7-git-send-email-jsnow@redhat.com \
    --to=jsnow@redhat.com \
    --cc=famz@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).