qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Apfelbaum <marcel@redhat.com>
To: qemu-devel@nongnu.org
Cc: marcel@redhat.com, mst@redhat.com, pbonzini@redhat.com,
	imammedo@redhat.com, lersek@redhat.com, ehabkost@redhat.com,
	peter.maydell@linaro.org
Subject: [Qemu-devel] [PATCH V5 4/7] hw/acpi: fix a DSDT table issue when a pxb is present.
Date: Sun, 17 Jul 2016 19:53:11 +0300	[thread overview]
Message-ID: <1468774394-23009-5-git-send-email-marcel@redhat.com> (raw)
In-Reply-To: <1468774394-23009-1-git-send-email-marcel@redhat.com>

PXBs do not support hotplug so they don't have a PCNT function.
Since the PXB's PCI root-bus is a child bus of bus 0, the
build_dsdt code will add a call to the corresponding PCNT function.

Fix this by skipping the PCNT call for the above case.
While at it skip also PCIe child buses.

Reported-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
Tested-by: Laszlo Ersek <lersek@redhat.com>
---
 hw/i386/acpi-build.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index fbba461..5ed2bbd 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -597,6 +597,10 @@ static void build_append_pci_bus_devices(Aml *parent_scope, PCIBus *bus,
         QLIST_FOREACH(sec, &bus->child, sibling) {
             int32_t devfn = sec->parent_dev->devfn;
 
+            if (pci_bus_is_root(sec) || pci_bus_is_express(sec)) {
+                continue;
+            }
+
             aml_append(method, aml_name("^S%.02X.PCNT", devfn));
         }
     }
-- 
2.4.3

  parent reply	other threads:[~2016-07-17 16:53 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-17 16:53 [Qemu-devel] [PATCH V5 0/7] pxb: fix 64-bit MMIO allocation Marcel Apfelbaum
2016-07-17 16:53 ` [Qemu-devel] [PATCH V5 1/7] hw/pcie-root-port: Fix PCIe root port initialization Marcel Apfelbaum
2016-07-17 16:53 ` [Qemu-devel] [PATCH V5 2/7] tests/acpi: add pxb/pxb-pcie tests Marcel Apfelbaum
2016-07-18 13:34   ` Igor Mammedov
2016-07-18 14:17     ` Marcel Apfelbaum
2016-07-18 14:54       ` Igor Mammedov
2016-07-18 19:27         ` Marcel Apfelbaum
2016-07-18 17:52     ` Laszlo Ersek
2016-07-18 19:32       ` Marcel Apfelbaum
2016-07-18 20:08         ` Laszlo Ersek
2016-07-19  9:06           ` [Qemu-devel] edk2 submodule + binaries (Re: [PATCH V5 2/7] tests/acpi: add pxb/pxb-pcie tests) Gerd Hoffmann
2016-07-19  9:30             ` Peter Maydell
2016-07-19 10:05               ` Gerd Hoffmann
2016-07-19 10:40                 ` Laszlo Ersek
2016-07-19  9:59             ` Laszlo Ersek
2016-07-19 10:13               ` Laszlo Ersek
2016-07-19 10:48               ` Gerd Hoffmann
2016-07-19 11:42                 ` Laszlo Ersek
2016-07-19 12:46                   ` Gerd Hoffmann
2016-07-19 14:25                   ` Marcel Apfelbaum
2016-07-19  7:34   ` [Qemu-devel] [PATCH V5 2/7] tests/acpi: add pxb/pxb-pcie tests Igor Mammedov
2016-07-19  8:10     ` Marcel Apfelbaum
2016-07-17 16:53 ` [Qemu-devel] [PATCH V5 3/7] hw/pxb: declare pxb devices as not hot-pluggable Marcel Apfelbaum
2016-07-17 16:53 ` Marcel Apfelbaum [this message]
2016-07-17 16:53 ` [Qemu-devel] [PATCH V5 5/7] acpi: refactor pxb crs computation Marcel Apfelbaum
2016-07-17 16:53 ` [Qemu-devel] [PATCH V5 6/7] hw/apci: handle 64-bit MMIO regions correctly Marcel Apfelbaum
2016-07-17 16:53 ` [Qemu-devel] [PATCH V5 7/7] tests/acpi: Add pxb/pxb-pcie tests blobs Marcel Apfelbaum
2016-07-19  5:30 ` [Qemu-devel] [PATCH V5 0/7] pxb: fix 64-bit MMIO allocation Marcel Apfelbaum
2016-07-26 18:30 ` Michael S. Tsirkin
2016-07-27  4:27   ` Marcel Apfelbaum
2016-07-27  4:43     ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1468774394-23009-5-git-send-email-marcel@redhat.com \
    --to=marcel@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=lersek@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).