From: Jason Wang <jasowang@redhat.com>
To: peter.maydell@linaro.org, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, Jason Wang <jasowang@redhat.com>
Subject: [Qemu-devel] [PULL V2 3/6] net: fix incorrect argument to iov_to_buf
Date: Tue, 19 Jul 2016 10:38:52 +0800 [thread overview]
Message-ID: <1468895935-23097-4-git-send-email-jasowang@redhat.com> (raw)
In-Reply-To: <1468895935-23097-1-git-send-email-jasowang@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Coverity reports a "suspicious sizeof" which is indeed wrong.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
net/eth.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/eth.c b/net/eth.c
index c147c2e..df81efb 100644
--- a/net/eth.c
+++ b/net/eth.c
@@ -418,7 +418,7 @@ _eth_get_rss_ex_dst_addr(const struct iovec *pkt, int pkt_frags,
bytes_read = iov_to_buf(pkt, pkt_frags,
rthdr_offset + sizeof(*ext_hdr),
- dst_addr, sizeof(dst_addr));
+ dst_addr, sizeof(*dst_addr));
return bytes_read == sizeof(dst_addr);
}
@@ -467,7 +467,7 @@ _eth_get_rss_ex_src_addr(const struct iovec *pkt, int pkt_frags,
bytes_read = iov_to_buf(pkt, pkt_frags,
opt_offset + sizeof(opthdr),
- src_addr, sizeof(src_addr));
+ src_addr, sizeof(*src_addr));
return bytes_read == sizeof(src_addr);
}
--
2.7.4
next prev parent reply other threads:[~2016-07-19 2:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-19 2:38 [Qemu-devel] [PULL V2 0/6] Net patches Jason Wang
2016-07-19 2:38 ` [Qemu-devel] [PULL V2 1/6] e1000e: fix incorrect access to pointer Jason Wang
2016-07-19 2:38 ` [Qemu-devel] [PULL V2 2/6] net: " Jason Wang
2016-07-19 2:38 ` Jason Wang [this message]
2016-07-19 2:38 ` [Qemu-devel] [PULL V2 4/6] tap: fix memory leak on failure to create a multiqueue tap device Jason Wang
2016-07-19 2:38 ` [Qemu-devel] [PULL V2 5/6] MAINTAINERS: release Scott from being a rocker maintainer Jason Wang
2016-07-19 2:38 ` [Qemu-devel] [PULL V2 6/6] e1000e: fix building without CONFIG_VMXNET3_PCI Jason Wang
2016-07-19 12:41 ` [Qemu-devel] [PULL V2 0/6] Net patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1468895935-23097-4-git-send-email-jasowang@redhat.com \
--to=jasowang@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).