qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v6 3/8] tests/docker/docker.py: check and run .pre script
Date: Tue, 19 Jul 2016 16:16:43 +0800	[thread overview]
Message-ID: <1468916208-18668-4-git-send-email-famz@redhat.com> (raw)
In-Reply-To: <1468916208-18668-1-git-send-email-famz@redhat.com>

From: Alex Bennée <alex.bennee@linaro.org>

The docker script will now search for an associated $dockerfile.pre
script which gets run in the same build context as the dockerfile will
be. This is to support pre-seeding the build context before running the
docker build.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-id: 1468335639-24582-4-git-send-email-alex.bennee@linaro.org
---
 tests/docker/docker.py | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/tests/docker/docker.py b/tests/docker/docker.py
index 96d906e..b61d934 100755
--- a/tests/docker/docker.py
+++ b/tests/docker/docker.py
@@ -221,6 +221,18 @@ class BuildCommand(SubCommand):
             # Create a docker context directory for the build
             docker_dir = tempfile.mkdtemp(prefix="docker_build")
 
+            # Is there a .pre file to run in the build context?
+            docker_pre = os.path.splitext(args.dockerfile)[0]+".pre"
+            if os.path.exists(docker_pre):
+                rc = subprocess.call(os.path.realpath(docker_pre),
+                                     cwd=docker_dir)
+                if rc == 3:
+                    print "Skip"
+                    return 0
+                else:
+                    print "%s exited with code %d" % (docker_pre, rc)
+                    return 1
+
             # Do we include a extra binary?
             if args.include_executable:
                 _copy_binary_with_libs(args.include_executable,
-- 
2.7.4

  parent reply	other threads:[~2016-07-19  8:17 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-19  8:16 [Qemu-devel] [PATCH v6 0/8] docker: Support building qemu-user powered docker test images Fam Zheng
2016-07-19  8:16 ` [Qemu-devel] [PATCH v6 1/8] tests/docker/docker.py: docker_dir outside build Fam Zheng
2016-07-19  8:16 ` [Qemu-devel] [PATCH v6 2/8] tests/docker/docker.py: support --include-executable Fam Zheng
2016-07-19 11:06   ` Daniel P. Berrange
2016-07-19 11:28     ` Alex Bennée
2016-07-19  8:16 ` Fam Zheng [this message]
2016-07-19  9:29   ` [Qemu-devel] [PATCH v6 3/8] tests/docker/docker.py: check and run .pre script Alex Bennée
2016-07-19 11:44     ` Fam Zheng
2016-07-19  8:16 ` [Qemu-devel] [PATCH v6 4/8] tests/docker/dockerfiles: new debian-bootstrap.docker Fam Zheng
2016-07-19  9:00   ` Alex Bennée
2016-07-19  8:16 ` [Qemu-devel] [PATCH v6 5/8] tests/docker/docker.py: add update operation Fam Zheng
2016-07-19  8:16 ` [Qemu-devel] [PATCH v6 6/8] docker: More sensible run script Fam Zheng
2016-07-19  8:16 ` [Qemu-devel] [PATCH v6 7/8] docker: Fix exit code if $CMD failed Fam Zheng
2016-07-19  8:16 ` [Qemu-devel] [PATCH v6 8/8] docker: Don't start a container that doesn't exist Fam Zheng
2016-07-19 10:43   ` Alex Bennée
2016-07-19  9:58 ` [Qemu-devel] [PATCH v6 0/8] docker: Support building qemu-user powered docker test images Alex Bennée
2016-07-19 10:59 ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1468916208-18668-4-git-send-email-famz@redhat.com \
    --to=famz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).