From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Antonio Borneo <borneo.antonio@gmail.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: [Qemu-devel] [PULL 03/12] hw/i386: add device tree support
Date: Tue, 19 Jul 2016 10:34:10 +0200 [thread overview]
Message-ID: <1468917259-8475-4-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1468917259-8475-1-git-send-email-pbonzini@redhat.com>
From: Antonio Borneo <borneo.antonio@gmail.com>
With "-dtb" on command-line:
- append the device tree blob to the kernel image;
- pass the blob's pointer to the kernel through setup_data, as
requested by upstream kernel commit da6b737b9ab7 ("x86: Add
device tree support").
The device tree blob is passed as-is to the guest; none of its
fields is modified nor updated. This is not an issue; the kernel
commit above uses the device tree only as an extension to the
traditional kernel configuration.
To: "Michael S. Tsirkin" <mst@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
To: Richard Henderson <rth@twiddle.net>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Message-Id: <1459973054-2777-1-git-send-email-borneo.antonio@gmail.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/i386/pc.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 46 insertions(+)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 1b8baa8..719884f 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -812,11 +812,26 @@ static long get_file_size(FILE *f)
return size;
}
+/* setup_data types */
+#define SETUP_NONE 0
+#define SETUP_E820_EXT 1
+#define SETUP_DTB 2
+#define SETUP_PCI 3
+#define SETUP_EFI 4
+
+struct setup_data {
+ uint64_t next;
+ uint32_t type;
+ uint32_t len;
+ uint8_t data[0];
+} __attribute__((packed));
+
static void load_linux(PCMachineState *pcms,
FWCfgState *fw_cfg)
{
uint16_t protocol;
int setup_size, kernel_size, initrd_size = 0, cmdline_size;
+ int dtb_size, setup_data_offset;
uint32_t initrd_max;
uint8_t header[8192], *setup, *kernel, *initrd_data;
hwaddr real_addr, prot_addr, cmdline_addr, initrd_addr = 0;
@@ -824,8 +839,10 @@ static void load_linux(PCMachineState *pcms,
char *vmode;
MachineState *machine = MACHINE(pcms);
PCMachineClass *pcmc = PC_MACHINE_GET_CLASS(pcms);
+ struct setup_data *setup_data;
const char *kernel_filename = machine->kernel_filename;
const char *initrd_filename = machine->initrd_filename;
+ const char *dtb_filename = machine->dtb;
const char *kernel_cmdline = machine->kernel_cmdline;
/* Align to 16 bytes as a paranoia measure */
@@ -988,6 +1005,35 @@ static void load_linux(PCMachineState *pcms,
exit(1);
}
fclose(f);
+
+ /* append dtb to kernel */
+ if (dtb_filename) {
+ if (protocol < 0x209) {
+ fprintf(stderr, "qemu: Linux kernel too old to load a dtb\n");
+ exit(1);
+ }
+
+ dtb_size = get_image_size(dtb_filename);
+ if (dtb_size <= 0) {
+ fprintf(stderr, "qemu: error reading dtb %s: %s\n",
+ dtb_filename, strerror(errno));
+ exit(1);
+ }
+
+ setup_data_offset = QEMU_ALIGN_UP(kernel_size, 16);
+ kernel_size = setup_data_offset + sizeof(struct setup_data) + dtb_size;
+ kernel = g_realloc(kernel, kernel_size);
+
+ stq_p(header+0x250, prot_addr + setup_data_offset);
+
+ setup_data = (struct setup_data *)(kernel + setup_data_offset);
+ setup_data->next = 0;
+ setup_data->type = cpu_to_le32(SETUP_DTB);
+ setup_data->len = cpu_to_le32(dtb_size);
+
+ load_image_size(dtb_filename, setup_data->data, dtb_size);
+ }
+
memcpy(setup, header, MIN(sizeof(header), setup_size));
fw_cfg_add_i32(fw_cfg, FW_CFG_KERNEL_ADDR, prot_addr);
--
2.7.4
next prev parent reply other threads:[~2016-07-19 8:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-19 8:34 [Qemu-devel] [PULL v2 00/12] Misc patches for 2.7 hard freeze from 2016-07-18 Paolo Bonzini
2016-07-19 8:34 ` [Qemu-devel] [PULL 01/12] use g_path_get_dirname instead of dirname Paolo Bonzini
2016-07-19 8:34 ` [Qemu-devel] [PULL 02/12] Changed malloc to g_malloc, free to g_free in bsd-user/qemu.h Paolo Bonzini
2016-07-19 8:34 ` Paolo Bonzini [this message]
2016-07-19 8:34 ` [Qemu-devel] [PULL 04/12] compiler: never omit assertions if using a static analysis tool Paolo Bonzini
2016-07-19 8:34 ` [Qemu-devel] [PULL 05/12] megasas: remove useless check for cmd->frame Paolo Bonzini
2016-07-19 8:34 ` [Qemu-devel] [PULL 06/12] checkpatch: consider git extended headers valid patches Paolo Bonzini
2016-07-19 8:34 ` [Qemu-devel] [PULL 07/12] exec: avoid realloc in phys_map_node_reserve Paolo Bonzini
2016-07-19 8:34 ` [Qemu-devel] [PULL 08/12] cpu-exec: Move down some declarations in cpu_exec() Paolo Bonzini
2016-07-19 8:34 ` [Qemu-devel] [PULL 09/12] Move README to markdown Paolo Bonzini
2016-07-19 15:49 ` Daniel P. Berrange
2016-07-19 18:15 ` Pranith Kumar
2016-07-19 20:54 ` Peter Maydell
2016-07-19 8:34 ` [Qemu-devel] [PULL 10/12] block/iscsi: fix rounding in iscsi_allocationmap_set Paolo Bonzini
2016-07-19 8:34 ` [Qemu-devel] [PULL 11/12] block/iscsi: allow caching of the allocation map Paolo Bonzini
2016-07-19 8:34 ` [Qemu-devel] [PULL 12/12] target-i386: Remove redundant HF_SOFTMMU_MASK Paolo Bonzini
2016-07-19 15:39 ` [Qemu-devel] [PULL v2 00/12] Misc patches for 2.7 hard freeze from 2016-07-18 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1468917259-8475-4-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=bigeasy@linutronix.de \
--cc=borneo.antonio@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).