From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48420) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPYQo-0000Yo-Ge for qemu-devel@nongnu.org; Tue, 19 Jul 2016 13:03:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPYQm-0004zN-OE for qemu-devel@nongnu.org; Tue, 19 Jul 2016 13:03:41 -0400 Received: from orth.archaic.org.uk ([2001:8b0:1d0::2]:58375) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPYQm-0004zA-HK for qemu-devel@nongnu.org; Tue, 19 Jul 2016 13:03:40 -0400 Received: from pm215 by orth.archaic.org.uk with local (Exim 4.84_2) (envelope-from ) id 1bPYQm-0002yb-0b for qemu-devel@nongnu.org; Tue, 19 Jul 2016 18:03:40 +0100 From: Peter Maydell Date: Tue, 19 Jul 2016 18:03:34 +0100 Message-Id: <1468947815-9900-2-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1468947815-9900-1-git-send-email-peter.maydell@linaro.org> References: <1468947815-9900-1-git-send-email-peter.maydell@linaro.org> Subject: [Qemu-devel] [PULL 1/2] target-arm: Fix unreachable code in gicv3_class_name() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Coverity complains that the exit() in gicv3_class_name() can be unreachable, because if TARGET_AARCH64 is defined then all code paths return before reaching it. Move the exit() up to the error_report() that it belongs with. Signed-off-by: Peter Maydell Reviewed-by: Shannon Zhao Message-id: 1468260552-8400-1-git-send-email-peter.maydell@linaro.org --- target-arm/machine.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target-arm/machine.c b/target-arm/machine.c index 2dbeb82..7a6ca31 100644 --- a/target-arm/machine.c +++ b/target-arm/machine.c @@ -340,10 +340,9 @@ const char *gicv3_class_name(void) #else error_report("KVM GICv3 acceleration is not supported on this " "platform"); + exit(1); #endif } else { return "arm-gicv3"; } - - exit(1); } -- 1.9.1