From: Gerd Hoffmann <kraxel@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Marcel Apfelbaum <marcel@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH V2] hw/virtio-pci: fix virtio behaviour on modern (PCIe) machines
Date: Wed, 20 Jul 2016 10:41:07 +0200 [thread overview]
Message-ID: <1469004067.3363.34.camel@redhat.com> (raw)
In-Reply-To: <20160720013838-mutt-send-email-mst@kernel.org>
> > Notes:
> > - The non PCIe machines behaviour should remain the same.
> > - I hope is OK to make the disable-* properties OnOffAuto. Previous setups
> > using them can be affected,
>
> why? could you explain pls? isn't onoffauto compatible with bit
> properties?
I have the same question ;)
> Also, I wonder how does this interact with devices that play with
> these flags themselves, like virtio gpu?
virtio input forces virtio 1.0 only too.
I think they must be changed to set the new property variables instead.
> I guess we could just set VIRTIO_PCI_FLAG_DISABLE_LEGACY, avoid clearing it.
I think we should simply drop the flags and use bool variables instead.
Also while being at it: Should we enable modern by default for all pci
devices?
cheers,
Gerd
next prev parent reply other threads:[~2016-07-20 8:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-19 18:42 [Qemu-devel] [PATCH V2] hw/virtio-pci: fix virtio behaviour on modern (PCIe) machines Marcel Apfelbaum
2016-07-19 22:56 ` Michael S. Tsirkin
2016-07-20 8:27 ` Marcel Apfelbaum
2016-07-20 8:41 ` Gerd Hoffmann [this message]
2016-07-20 9:01 ` Marcel Apfelbaum
2016-07-20 9:43 ` Gerd Hoffmann
2016-07-20 9:16 ` Cornelia Huck
2016-07-20 9:37 ` Marcel Apfelbaum
2016-07-20 11:23 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1469004067.3363.34.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).