From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51044)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1bPn45-0007PH-Lw
	for qemu-devel@nongnu.org; Wed, 20 Jul 2016 04:41:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1bPn43-0005B5-SR
	for qemu-devel@nongnu.org; Wed, 20 Jul 2016 04:41:12 -0400
Received: from mx1.redhat.com ([209.132.183.28]:60720)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1bPn43-0005Ao-Md
	for qemu-devel@nongnu.org; Wed, 20 Jul 2016 04:41:11 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 81F0D7F41A
	for <qemu-devel@nongnu.org>; Wed, 20 Jul 2016 08:41:10 +0000 (UTC)
Message-ID: <1469004067.3363.34.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Wed, 20 Jul 2016 10:41:07 +0200
In-Reply-To: <20160720013838-mutt-send-email-mst@kernel.org>
References: <1468953778-15295-1-git-send-email-marcel@redhat.com>
	<20160720013838-mutt-send-email-mst@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH V2] hw/virtio-pci: fix virtio behaviour on
 modern (PCIe) machines
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Marcel Apfelbaum <marcel@redhat.com>, qemu-devel@nongnu.org

> > Notes:
> >    - The non PCIe machines behaviour should remain the same.
> >    - I hope is OK to make the disable-* properties OnOffAuto. Previous =
setups
> >      using them can be affected,
>=20
> why? could you explain pls? isn't onoffauto compatible with bit
> properties?

I have the same question ;)

> Also, I wonder how does this interact with devices that play with
> these flags themselves, like virtio gpu?

virtio input forces virtio 1.0 only too.
I think they must be changed to set the new property variables instead.

> I guess we could just set VIRTIO_PCI_FLAG_DISABLE_LEGACY, avoid clearing =
it.

I think we should simply drop the flags and use bool variables instead.

Also while being at it:  Should we enable modern by default for all pci
devices?

cheers,
  Gerd