qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Colin Lord <clord@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, qemu-block@nongnu.org, mreitz@redhat.com,
	Colin Lord <clord@redhat.com>
Subject: [Qemu-devel] [PATCH v5 0/3] Dynamic module loading for block drivers
Date: Wed, 20 Jul 2016 10:30:47 -0400	[thread overview]
Message-ID: <1469025050-12715-1-git-send-email-clord@redhat.com> (raw)

Here's v5 of the modularization series. Since it seems the concensus is
that modularizing the format drivers is unnecessary, this series no
longer modularizes those and is thus much shorter than before.

v5:
- No format drivers are modularized, therefore the probe functions are
  all being left completely untouched. The bdrv_find_format function is
  also left untouched as a result.
- Remove dmg from block-obj-m since it is not a target of the
  modularization effort.
- Modify module_block.py to only include the library name and protocol
  name fields in the generated struct. The other fields are no longer
  necessary for the drivers that are being modularized.

v4:
- Fix indentation of the generated header file module_block.h
- Drivers and probe functions are now all located in the block/
  directory, rather than being split between block/ and block/probe/. In
  addition the header files for each probe/driver pair are in the block/
  directory, not the include/block/driver/ directory (which no longer
  exists).
- Since the probe files are in block/ now, they follow the naming
  pattern of format-probe.c
- Renamed crypto probe file to be crypto-probe.c, luks is no longer in
  the filename
- Fixed formatting of parallels_probe() function header
- Enforced consistent naming convention for the probe functions. They
  now follow the pattern bdrv_format_probe().

Colin Lord (1):
  blockdev: prepare iSCSI block driver for dynamic loading

Marc Mari (2):
  blockdev: Add dynamic generation of module_block.h
  blockdev: Add dynamic module loading for block drivers

 Makefile                        |   7 +++
 block.c                         |  37 ++++++++++++---
 block/Makefile.objs             |   3 +-
 block/iscsi.c                   |  36 --------------
 include/qemu/module.h           |   3 ++
 scripts/modules/module_block.py | 102 ++++++++++++++++++++++++++++++++++++++++
 util/module.c                   |  38 +++++----------
 vl.c                            |  38 +++++++++++++++
 8 files changed, 193 insertions(+), 71 deletions(-)
 create mode 100644 scripts/modules/module_block.py

-- 
2.5.5

             reply	other threads:[~2016-07-20 14:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-20 14:30 Colin Lord [this message]
2016-07-20 14:30 ` [Qemu-devel] [PATCH v5 1/3] blockdev: prepare iSCSI block driver for dynamic loading Colin Lord
2016-07-20 14:30 ` [Qemu-devel] [PATCH v5 2/3] blockdev: Add dynamic generation of module_block.h Colin Lord
2016-07-20 14:30 ` [Qemu-devel] [PATCH v5 3/3] blockdev: Add dynamic module loading for block drivers Colin Lord
2016-07-23 18:21 ` [Qemu-devel] [PATCH v5 0/3] Dynamic " Max Reitz
2016-07-25 13:56   ` Colin Lord
2016-07-25 19:38     ` Max Reitz
2016-07-29  6:33     ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1469025050-12715-1-git-send-email-clord@redhat.com \
    --to=clord@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).