From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Peter Crosthwaite <crosthwaite.peter@gmail.com>,
Richard Henderson <rth@twiddle.net>,
Eduardo Habkost <ehabkost@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>,
Alexander Graf <agraf@suse.de>, Riku Voipio <riku.voipio@iki.fi>,
Bharata B Rao <bharata@linux.vnet.ibm.com>,
qemu-ppc@nongnu.org
Subject: [Qemu-devel] [PATCH 6/8] spapr: init CPUState->cpu_index with index relative to core-id
Date: Thu, 21 Jul 2016 17:54:37 +0200 [thread overview]
Message-ID: <1469116479-233280-7-git-send-email-imammedo@redhat.com> (raw)
In-Reply-To: <1469116479-233280-1-git-send-email-imammedo@redhat.com>
It will enshure that cpu_index for a given cpu stays the same
regardless of the order cpus has been created/deleted and so
it would be possible to migrate QEMU instance with out of order
created CPU.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
hw/ppc/spapr_cpu_core.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/hw/ppc/spapr_cpu_core.c b/hw/ppc/spapr_cpu_core.c
index 4bfc96b..f68e88d 100644
--- a/hw/ppc/spapr_cpu_core.c
+++ b/hw/ppc/spapr_cpu_core.c
@@ -309,9 +309,13 @@ static void spapr_cpu_core_realize(DeviceState *dev, Error **errp)
sc->threads = g_malloc0(size * cc->nr_threads);
for (i = 0; i < cc->nr_threads; i++) {
char id[32];
+ CPUState *cs;
+
obj = sc->threads + i * size;
object_initialize(obj, size, typename);
+ cs = CPU(obj);
+ cs->cpu_index = cc->core_id + i;
snprintf(id, sizeof(id), "thread[%d]", i);
object_property_add_child(OBJECT(sc), id, obj, &local_err);
if (local_err) {
--
2.7.4
next prev parent reply other threads:[~2016-07-21 15:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-21 15:54 [Qemu-devel] [PATCH 0/8] Fix migration issues with arbitrary cpu-hot(un)plug Igor Mammedov
2016-07-21 15:54 ` [Qemu-devel] [PATCH 1/8] exec: reduce CONFIG_USER_ONLY ifdeffenery Igor Mammedov
2016-07-22 1:30 ` David Gibson
2016-07-21 15:54 ` [Qemu-devel] [PATCH 2/8] exec: don't use cpu_index to detect if cpu_exec_init()'s been called for cpu Igor Mammedov
2016-07-22 1:32 ` David Gibson
2016-07-22 20:46 ` Eduardo Habkost
2016-07-25 8:30 ` Igor Mammedov
2016-07-21 15:54 ` [Qemu-devel] [PATCH 3/8] exec: set cpu_index only if it's been explictly set Igor Mammedov
2016-07-22 1:35 ` David Gibson
2016-07-21 15:54 ` [Qemu-devel] [PATCH 4/8] qdev: fix object reference leak in case device.realize() fails Igor Mammedov
2016-07-22 1:39 ` David Gibson
2016-07-21 15:54 ` [Qemu-devel] [PATCH 5/8] pc: init CPUState->cpu_index with index in possible_cpus[] Igor Mammedov
2016-07-22 1:41 ` David Gibson
2016-07-21 15:54 ` Igor Mammedov [this message]
2016-07-22 3:23 ` [Qemu-devel] [PATCH 6/8] spapr: init CPUState->cpu_index with index relative to core-id David Gibson
2016-07-22 6:10 ` Bharata B Rao
2016-07-22 7:14 ` David Gibson
2016-07-22 7:20 ` Bharata B Rao
2016-07-22 8:42 ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
2016-07-26 3:27 ` [Qemu-devel] " David Gibson
2016-07-21 15:54 ` [Qemu-devel] [PATCH 7/8] Revert "pc: Enforce adding CPUs contiguously and removing them in opposite order" Igor Mammedov
2016-07-21 15:54 ` [Qemu-devel] [PATCH 8/8] Revert "spapr: Ensure CPU cores are added contiguously and removed in LIFO order" Igor Mammedov
2016-07-21 21:56 ` [Qemu-devel] [PATCH 0/8] Fix migration issues with arbitrary cpu-hot(un)plug Michael S. Tsirkin
2016-07-22 4:35 ` David Gibson
2016-07-22 10:01 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1469116479-233280-7-git-send-email-imammedo@redhat.com \
--to=imammedo@redhat.com \
--cc=agraf@suse.de \
--cc=bharata@linux.vnet.ibm.com \
--cc=crosthwaite.peter@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=ehabkost@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).