qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Cornelia Huck <cornelia.huck@de.ibm.com>,
	Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PULL v5 55/57] virtio-gpu: Wrap in vmstate
Date: Thu, 21 Jul 2016 20:55:38 +0300	[thread overview]
Message-ID: <1469123413-20809-56-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1469123413-20809-1-git-send-email-mst@redhat.com>

From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

Forcibly convert it to a vmstate wrapper;  proper conversion
comes later.

Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
---
 hw/display/virtio-gpu.c | 17 +++++++----------
 1 file changed, 7 insertions(+), 10 deletions(-)

diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c
index cc87eb7..7fe6ed8 100644
--- a/hw/display/virtio-gpu.c
+++ b/hw/display/virtio-gpu.c
@@ -987,7 +987,7 @@ static const VMStateDescription vmstate_virtio_gpu_scanouts = {
     },
 };
 
-static void virtio_gpu_save(QEMUFile *f, void *opaque)
+static void virtio_gpu_save(QEMUFile *f, void *opaque, size_t size)
 {
     VirtIOGPU *g = opaque;
     VirtIODevice *vdev = VIRTIO_DEVICE(g);
@@ -1017,7 +1017,7 @@ static void virtio_gpu_save(QEMUFile *f, void *opaque)
     vmstate_save_state(f, &vmstate_virtio_gpu_scanouts, g, NULL);
 }
 
-static int virtio_gpu_load(QEMUFile *f, void *opaque, int version_id)
+static int virtio_gpu_load(QEMUFile *f, void *opaque, size_t size)
 {
     VirtIOGPU *g = opaque;
     VirtIODevice *vdev = VIRTIO_DEVICE(g);
@@ -1026,11 +1026,7 @@ static int virtio_gpu_load(QEMUFile *f, void *opaque, int version_id)
     uint32_t resource_id, pformat;
     int i, ret;
 
-    if (version_id != VIRTIO_GPU_VM_VERSION) {
-        return -EINVAL;
-    }
-
-    ret = virtio_load(vdev, f, version_id);
+    ret = virtio_load(vdev, f, VIRTIO_GPU_VM_VERSION);
     if (ret) {
         return ret;
     }
@@ -1167,9 +1163,6 @@ static void virtio_gpu_device_realize(DeviceState *qdev, Error **errp)
     if (virtio_gpu_virgl_enabled(g->conf)) {
         error_setg(&g->migration_blocker, "virgl is not yet migratable");
         migrate_add_blocker(g->migration_blocker);
-    } else {
-        register_savevm(qdev, "virtio-gpu", -1, VIRTIO_GPU_VM_VERSION,
-                        virtio_gpu_save, virtio_gpu_load, g);
     }
 }
 
@@ -1226,6 +1219,9 @@ static void virtio_gpu_reset(VirtIODevice *vdev)
 #endif
 }
 
+VMSTATE_VIRTIO_DEVICE(gpu, VIRTIO_GPU_VM_VERSION, virtio_gpu_load,
+                      virtio_gpu_save);
+
 static Property virtio_gpu_properties[] = {
     DEFINE_PROP_UINT32("max_outputs", VirtIOGPU, conf.max_outputs, 1),
 #ifdef CONFIG_VIRGL
@@ -1252,6 +1248,7 @@ static void virtio_gpu_class_init(ObjectClass *klass, void *data)
     vdc->reset = virtio_gpu_reset;
 
     dc->props = virtio_gpu_properties;
+    dc->vmsd = &vmstate_virtio_gpu;
 }
 
 static const TypeInfo virtio_gpu_info = {
-- 
MST

  parent reply	other threads:[~2016-07-21 17:55 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-21 17:50 [Qemu-devel] [PULL v5 00/57] pc, pci, virtio: new features, cleanups, fixes Michael S. Tsirkin
2016-07-21 17:50 ` [Qemu-devel] [PULL v5 01/57] nvdimm: fix memory leak in error code path Michael S. Tsirkin
2016-07-21 17:51 ` [Qemu-devel] [PULL v5 02/57] tests/prom-env-test: increase the test timeout Michael S. Tsirkin
2016-07-21 17:51 ` [Qemu-devel] [PULL v5 03/57] hw/alpha: fix PCI bus initialization Michael S. Tsirkin
2016-07-21 17:51 ` [Qemu-devel] [PULL v5 04/57] hw/mips: " Michael S. Tsirkin
2016-07-21 17:51 ` [Qemu-devel] [PULL v5 05/57] hw/apb: " Michael S. Tsirkin
2016-07-21 17:51 ` [Qemu-devel] [PULL v5 06/57] hw/grackle: " Michael S. Tsirkin
2016-07-21 17:51 ` [Qemu-devel] [PULL v5 07/57] hw/prep: realize the PCI root bus as part of the prep init Michael S. Tsirkin
2016-07-21 17:51 ` [Qemu-devel] [PULL v5 08/57] hw/versatile: realize the PCI root bus as part of the versatile init Michael S. Tsirkin
2016-07-21 17:51 ` [Qemu-devel] [PULL v5 09/57] x86-iommu: introduce parent class Michael S. Tsirkin
2016-07-21 17:51 ` [Qemu-devel] [PULL v5 10/57] intel_iommu: rename VTD_PCI_DEVFN_MAX to x86-iommu Michael S. Tsirkin
2016-07-21 17:51 ` [Qemu-devel] [PULL v5 11/57] x86-iommu: provide x86_iommu_get_default Michael S. Tsirkin
2016-07-21 17:51 ` [Qemu-devel] [PULL v5 12/57] x86-iommu: introduce "intremap" property Michael S. Tsirkin
2016-07-21 17:51 ` [Qemu-devel] [PULL v5 13/57] acpi: enable INTR for DMAR report structure Michael S. Tsirkin
2016-07-21 17:52 ` [Qemu-devel] [PULL v5 14/57] intel_iommu: allow queued invalidation for IR Michael S. Tsirkin
2016-07-21 17:52 ` [Qemu-devel] [PULL v5 15/57] intel_iommu: set IR bit for ECAP register Michael S. Tsirkin
2016-07-21 17:52 ` [Qemu-devel] [PULL v5 16/57] acpi: add DMAR scope definition for root IOAPIC Michael S. Tsirkin
2016-07-21 17:52 ` [Qemu-devel] [PULL v5 17/57] intel_iommu: define interrupt remap table addr register Michael S. Tsirkin
2016-07-21 17:52 ` [Qemu-devel] [PULL v5 18/57] intel_iommu: handle interrupt remap enable Michael S. Tsirkin
2016-07-21 17:52 ` [Qemu-devel] [PULL v5 19/57] intel_iommu: define several structs for IOMMU IR Michael S. Tsirkin
2016-07-21 17:52 ` [Qemu-devel] [PULL v5 20/57] intel_iommu: add IR translation faults defines Michael S. Tsirkin
2016-07-21 17:52 ` [Qemu-devel] [PULL v5 21/57] intel_iommu: Add support for PCI MSI remap Michael S. Tsirkin
2016-07-21 17:52 ` [Qemu-devel] [PULL v5 22/57] intel_iommu: get rid of {0} initializers Michael S. Tsirkin
2016-07-21 17:52 ` [Qemu-devel] [PULL v5 23/57] q35: ioapic: add support for emulated IOAPIC IR Michael S. Tsirkin
2016-07-21 17:52 ` [Qemu-devel] [PULL v5 24/57] ioapic: introduce ioapic_entry_parse() helper Michael S. Tsirkin
2016-07-21 17:53 ` [Qemu-devel] [PULL v5 25/57] intel_iommu: add support for split irqchip Michael S. Tsirkin
2016-07-21 17:53 ` [Qemu-devel] [PULL v5 26/57] x86-iommu: introduce IEC notifiers Michael S. Tsirkin
2016-07-30  7:52   ` Jan Kiszka
2016-07-31  3:59     ` Peter Xu
2016-07-31 12:01       ` Jan Kiszka
2016-07-31 12:51         ` Peter Xu
2016-07-21 17:53 ` [Qemu-devel] [PULL v5 27/57] ioapic: register IOMMU IEC notifier for ioapic Michael S. Tsirkin
2016-07-21 17:53 ` [Qemu-devel] [PULL v5 28/57] intel_iommu: Add support for Extended Interrupt Mode Michael S. Tsirkin
2016-07-21 17:53 ` [Qemu-devel] [PULL v5 29/57] intel_iommu: add SID validation for IR Michael S. Tsirkin
2016-08-01 16:39   ` Jan Kiszka
2016-08-02  8:36     ` Peter Xu
2016-08-02  8:46       ` Jan Kiszka
     [not found]         ` <CABdVeADOKgSCJoFDSDufQxDa9PmiFyiEx=FtS043vyJsZXM3sA@mail.gmail.com>
2016-08-02  8:59           ` Jan Kiszka
2016-08-02 10:28         ` Peter Xu
2016-08-02 11:58           ` David Kiarie
2016-08-02 12:12             ` Peter Xu
2016-08-02 12:17               ` David Kiarie
2016-08-02 12:28                 ` Jan Kiszka
2016-08-08  9:06                 ` Peter Xu
2016-08-08  9:44                   ` David Kiarie
2016-08-02 12:16             ` Jan Kiszka
2016-08-02 12:18               ` David Kiarie
2016-07-21 17:53 ` [Qemu-devel] [PULL v5 30/57] kvm-irqchip: simplify kvm_irqchip_add_msi_route Michael S. Tsirkin
2016-07-21 17:53 ` [Qemu-devel] [PULL v5 31/57] kvm-irqchip: i386: add hook for add/remove virq Michael S. Tsirkin
2016-07-21 17:53 ` [Qemu-devel] [PULL v5 32/57] kvm-irqchip: x86: add msi route notify fn Michael S. Tsirkin
2016-07-21 17:53 ` [Qemu-devel] [PULL v5 33/57] kvm-irqchip: do explicit commit when update irq Michael S. Tsirkin
2016-07-21 17:53 ` [Qemu-devel] [PULL v5 34/57] intel_iommu: support all masks in interrupt entry cache invalidation Michael S. Tsirkin
2016-07-21 17:53 ` [Qemu-devel] [PULL v5 35/57] kvm-all: add trace events for kvm irqchip ops Michael S. Tsirkin
2016-07-21 17:54 ` [Qemu-devel] [PULL v5 36/57] intel_iommu: disallow kernel-irqchip=on with IR Michael S. Tsirkin
2016-07-21 17:54 ` [Qemu-devel] [PULL v5 37/57] virtio: Add typedef for handle_output Michael S. Tsirkin
2016-07-21 17:54 ` [Qemu-devel] [PULL v5 38/57] virtio: Introduce virtio_add_queue_aio Michael S. Tsirkin
2016-07-21 17:54 ` [Qemu-devel] [PULL v5 39/57] virtio-blk: Call virtio_add_queue_aio Michael S. Tsirkin
2016-07-21 17:54 ` [Qemu-devel] [PULL v5 40/57] virtio-scsi: " Michael S. Tsirkin
2016-07-21 17:54 ` [Qemu-devel] [PULL v5 41/57] Revert "mirror: Workaround for unexpected iohandler events during completion" Michael S. Tsirkin
2016-07-21 17:54 ` [Qemu-devel] [PULL v5 42/57] virtio-scsi: Replace HandleOutput typedef Michael S. Tsirkin
2016-07-21 17:54 ` [Qemu-devel] [PULL v5 43/57] virtio-net: Remove old migration version support Michael S. Tsirkin
2016-07-21 17:54 ` [Qemu-devel] [PULL v5 44/57] virtio-serial: " Michael S. Tsirkin
2016-07-21 17:54 ` [Qemu-devel] [PULL v5 45/57] virtio: Migration helper function and macro Michael S. Tsirkin
2016-07-21 17:54 ` [Qemu-devel] [PULL v5 46/57] virtio-scsi: Wrap in vmstate Michael S. Tsirkin
2016-07-21 17:54 ` [Qemu-devel] [PULL v5 47/57] virtio-blk: " Michael S. Tsirkin
2016-07-21 17:55 ` [Qemu-devel] [PULL v5 48/57] virtio-rng: " Michael S. Tsirkin
2016-07-21 17:55 ` [Qemu-devel] [PULL v5 49/57] virtio-balloon: " Michael S. Tsirkin
2016-07-21 17:55 ` [Qemu-devel] [PULL v5 50/57] virtio-net: " Michael S. Tsirkin
2016-07-21 17:55 ` [Qemu-devel] [PULL v5 51/57] virtio-serial: " Michael S. Tsirkin
2016-07-21 17:55 ` [Qemu-devel] [PULL v5 52/57] 9pfs: " Michael S. Tsirkin
2016-07-21 17:55 ` [Qemu-devel] [PULL v5 53/57] virtio-input: " Michael S. Tsirkin
2016-07-21 17:55 ` [Qemu-devel] [PULL v5 54/57] virtio-gpu: Use migrate_add_blocker for virgl migration blocking Michael S. Tsirkin
2016-07-21 17:55 ` Michael S. Tsirkin [this message]
2016-07-21 17:55 ` [Qemu-devel] [PULL v5 56/57] virtio: Update migration docs Michael S. Tsirkin
2016-07-21 17:55 ` [Qemu-devel] [PULL v5 57/57] intel_iommu: avoid unnamed fields Michael S. Tsirkin
2016-07-21 19:54 ` [Qemu-devel] [PULL v5 00/57] pc, pci, virtio: new features, cleanups, fixes Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1469123413-20809-56-git-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=dgilbert@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).